Skip to content

Record the Attached git Option Disproof and Qualify the Refusal Field Sentence - #2955

Merged
ptr727 merged 3 commits into
developfrom
feature/ledger-and-refusal-field
Oct 13, 2026
Merged

ptr727 merged 3 commits into
developfrom
feature/ledger-and-refusal-field

Conversation

@ptr727

@ptr727 ptr727 commented Oct 13, 2026

Copy link
Copy Markdown
Owner

Adds a Disproved Claims entry for the claim that git accepts an attached -c<name>=<value> or -C<dir> global option, and rewords the closing sentence of the scripts/README.md exit 41 paragraph to state when the digest's refusal= field and the exit code differ. Prose only, no code change.

Fixes #2941

A local strict review raised two findings on the first wording of the README sentence, both fixed. A second pass over the fix found none.

🤖 Generated with Claude Code

ptr727 and others added 2 commits October 13, 2026 13:27
…d Is Spent By

Add a Disproved Claims entry for the attached -c and -C global option claim, and reword the exit 41 sentence so the digest's refusal field and the exit code are stated as the separate readings the code has.

Fixes #2941

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ds Baseline

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 13, 2026 20:38
@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 22eff4e4-a546-4511-bd09-392f0882694c
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ptr727

ptr727 commented Oct 13, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head e28d4e61ee2563c8ed8c7c12dcfd0fdb228d34ba, the content this pull request carries at that commit against develop, and it recorded 2 findings.

@codecov

codecov Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.96%. Comparing base (ac78916) to head (a172d99).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2955   +/-   ##
========================================
  Coverage    59.96%   59.96%           
========================================
  Files           17       17           
  Lines         8778     8778           
========================================
  Hits          5264     5264           
  Misses        3514     3514           
Flag Coverage Δ
python-3.13 59.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new instruction entry needs to comply with the repository’s reference rule, and the added prose exceeds its sentence-length limit.

3 open findings
What changed in this PR

This prose-only PR records a git-option disproof for future reviews and clarifies how the review digest’s refusal= field can differ from wait exit code 41.

Changes:

  • Adds a Disproved Claims entry for attached git global options.
  • Clarifies the refusal field’s behavior when review rounds are ordered around a --min-rounds baseline.
File Description
scripts/​README.md Clarifies the refusal field and exit-code distinction.
.github/​copilot-instructions.md Records the git-option disproof.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/copilot-instructions.md Outdated
Comment thread .github/copilot-instructions.md Outdated
Comment thread scripts/README.md Outdated
…isproof and Refusal Wording

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ptr727

ptr727 commented Oct 13, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head a172d9946ac495710efe9ad5d17b69a050cd3ab8, the content this pull request carries at that commit against develop, and it recorded 0 findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Both prose changes address their stated purpose, and no unresolved findings remain.

0 open findings

3 resolved since last review

🧠 Review effort: Lite

@ptr727
ptr727 merged commit 3c8a008 into develop Oct 13, 2026
14 checks passed
ptr727 added a commit that referenced this pull request Oct 14, 2026
…ps, and the Refusal Field Wording to Main (#2965)

- #2963 makes `gh-write-guard` read each push refspec's own operation,
so a `+src` forces and a `:dst` deletes only its own branch while
`--force` and `--delete` reach every refspec, and every operation, force
and delete included, is checked against `pull_request`. A git command
under an `include.path` or `includeIf.<condition>.path` override whose
subcommand is not a known git command now denies, since the included
file may alias it to a push. A separator fused with a redirection (`;<`,
`&&<`, `|<` and similar) is read both ways, so the next command's words
no longer read as the push's refspecs. A differential against the
previous guard found every allow flip in the intended per-refspec class
and none under a rule set holding `pull_request`. The known new
over-denials are listed in that pull request, and the fixed-prefix
branch pattern case is #2964
- #2956 tightens the CLI usage gate: `tests/test_cli_usage.py` declares
the entry points that need no argument and fails one declared nowhere,
`CODESTYLE.md` "Command-Line Arguments" states the gate's stricter
reading of help and unknown-argument refusals, `scripts/carry.py` shares
one porcelain status parser with the gate, and the Windows UTF-8 decode
probe in `tests/test_prose_lint.py` now sees the reader thread's
exception
- #2955 records the attached `-c<name>=<value>` / `-C<dir>` git option
disproof in the Disproved Claims ledger and states in
`scripts/README.md` when the digest's `refusal=` field and `wait`'s exit
code differ

Closes #2941
Closes #2946
Closes #2947
Closes #2948
Closes #2949
Closes #2951

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@ptr727
ptr727 deleted the feature/ledger-and-refusal-field branch October 14, 2026 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants