Repository navigation
Record the Attached git Option Disproof and Qualify the Refusal Field Sentence - #2955
Conversation
…d Is Spent By Add a Disproved Claims entry for the attached -c and -C global option claim, and reword the exit 41 sentence so the digest's refusal field and the exit code are stated as the separate readings the code has. Fixes #2941 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ds Baseline Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
A recorded local strict-review pass covers head |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2955 +/- ##
========================================
Coverage 59.96% 59.96%
========================================
Files 17 17
Lines 8778 8778
========================================
Hits 5264 5264
Misses 3514 3514
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟡 Changes recommended
The new instruction entry needs to comply with the repository’s reference rule, and the added prose exceeds its sentence-length limit.
3 open findings
What changed in this PR
This prose-only PR records a git-option disproof for future reviews and clarifies how the review digest’s refusal= field can differ from wait exit code 41.
Changes:
- Adds a Disproved Claims entry for attached git global options.
- Clarifies the refusal field’s behavior when review rounds are ordered around a
--min-roundsbaseline.
| File | Description |
|---|---|
| scripts/README.md | Clarifies the refusal field and exit-code distinction. |
| .github/copilot-instructions.md | Records the git-option disproof. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…isproof and Refusal Wording Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
A recorded local strict-review pass covers head |
…ps, and the Refusal Field Wording to Main (#2965) - #2963 makes `gh-write-guard` read each push refspec's own operation, so a `+src` forces and a `:dst` deletes only its own branch while `--force` and `--delete` reach every refspec, and every operation, force and delete included, is checked against `pull_request`. A git command under an `include.path` or `includeIf.<condition>.path` override whose subcommand is not a known git command now denies, since the included file may alias it to a push. A separator fused with a redirection (`;<`, `&&<`, `|<` and similar) is read both ways, so the next command's words no longer read as the push's refspecs. A differential against the previous guard found every allow flip in the intended per-refspec class and none under a rule set holding `pull_request`. The known new over-denials are listed in that pull request, and the fixed-prefix branch pattern case is #2964 - #2956 tightens the CLI usage gate: `tests/test_cli_usage.py` declares the entry points that need no argument and fails one declared nowhere, `CODESTYLE.md` "Command-Line Arguments" states the gate's stricter reading of help and unknown-argument refusals, `scripts/carry.py` shares one porcelain status parser with the gate, and the Windows UTF-8 decode probe in `tests/test_prose_lint.py` now sees the reader thread's exception - #2955 records the attached `-c<name>=<value>` / `-C<dir>` git option disproof in the Disproved Claims ledger and states in `scripts/README.md` when the digest's `refusal=` field and `wait`'s exit code differ Closes #2941 Closes #2946 Closes #2947 Closes #2948 Closes #2949 Closes #2951 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Adds a Disproved Claims entry for the claim that git accepts an attached
-c<name>=<value>or-C<dir>global option, and rewords the closing sentence of thescripts/README.mdexit41paragraph to state when the digest'srefusal=field and the exit code differ. Prose only, no code change.Fixes #2941
A local strict review raised two findings on the first wording of the README sentence, both fixed. A second pass over the fix found none.
🤖 Generated with Claude Code