[Benchmark] add link - #40
Merged
Merged
Conversation
elecball
marked this pull request as draft
October 2, 2026 11:40
elecball
marked this pull request as ready for review
October 3, 2026 13:13
Contributor
|
안녕하세요. 기여에 참여해 주셔서 감사합니다. 다음 수정 사항들을 반영해 주세요 1. merge commit을 만들지 마세요.rebase를 사용하여 merge commit이 생성되지 않도록 해 주시기 바랍니다. 2. 다음 불일치들을 수정해 주세요구현과 명세를 수정하고, fuzzing 시나리오에도 추가하여 동일한 시드로 1000회 fuzzing 결과를 첨부해 주시기 바랍니다. a. 모호한 상황에서의 에러 메시지 출력 link --=GNU: Dafny: b. 입력 인자에서 유니코드 처리 오류 link '-é' 2>&1 | od -An -tx1 -v-GNU: 27 c3 27
+Dafny: 27 c3 a9 27GNU는 잘못된 옵션의 첫 번째 바이트만 출력하지만, 구현해 주신 Dafny |
Implement GNU link with its specification, proof, parity tests, documentation, and fuzzer support. Validation: - make check TASK=link - cargo test Co-authored-by: OpenAI Codex <codex@openai.com>
elecball
marked this pull request as draft
October 4, 2026 16:03
Match GNU output for ambiguous and non-ASCII options. Add randomized malformed-option fuzzing and a regression test. Validation: make check TASK=link; 3,000 fuzz cases passed. Co-authored-by: OpenAI Codex <codex@openai.com>
elecball
marked this pull request as ready for review
October 4, 2026 18:37
Contributor
|
fuzzing 결과도 다시 첨부해 주시기 바랍니다. Please attach the fuzzing results again. |
Contributor
Author
세 시드에 대해 전부 통과하였습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements GNU link and adds specifications, proofs, tests, and a fuzzer generator. (#11)
Change and scope
link, coreutils.ac71c9b336a5897caf5964b0267cafa1c101be3b./workspace/dafnyutils, Ubuntu 24.04 development container.4.11.1+1eb9fc5fa2661483de151ff85b21eed0b695878a, Python3.12.3.coreutils/src/link.cat2cf491412c199e2211880ec3f4ba387026638a33.bench/utils/link/link.md.coreutils/src/link.c--help,--version, long-option abbreviations, and--LinkSpec.Specunder the shared contractsOptions left out due to IO.dfy
None.
1. Test results
make -C bench/utils/link test: 28 passed, 3 proof tests deselected; exit 0.ruff check bench/utils/link/Tests.py,ruff format --check bench/utils/link/Tests.py, and Rust formatting passed.2. Fuzzing results
python3 tools/coreutils_fuzzer/run.py fuzz 'link' --seeds 1,7,19 --iterations 1000.3. Verification results
make -C bench/utils/link verify: 253 verified, 0 errors; exit 0.python3 -m benchmarks validate 'link': valid; exit 0.make check TASK=link:link: checks passed; exit 0.Progress notes
CreateHardLinkSpecdoes not guarantee filesystem preservation on failure. Behavior for symbolic-link sources is unspecified by GNU. Non-UTF-8 pathname bytes and closed-stream or/dev/fullparity are not established.bench/utils/link/link.md.AI usage
This contribution was based primarily on my existing GNU
unlinkbenchmark implementation. Codex reviewed and revised the adaptation forlink.