Conversation
Re-add the per-container (cadvisor) and redis (redis-exporter) metrics sidecars to the provider compose stack. These were added in #2058 then removed in 6d7c062 because they were mis-indented under redis-stack (so not real services) and redis-exporter lacked REDIS_ADDR. This restores them as correctly-indented top-level services with static IPs, fixes redis-exporter by pointing it at redis://redis-stack:6379, and runs cadvisor privileged with /dev/kmsg per the documented setup. Also mount the host's /proc and /sys into the vector container (with PROCFS_ROOT/SYSFS_ROOT) so the host_metrics source reports the real host rather than the vector container's namespaced view. The vector.toml scrape config for cadvisor:8080 and redis-exporter:9121 already survived the revert, so no vector config changes are needed.
Add two more metrics sidecars to the provider stack and wire them into vector's remote-write pipeline: - mongodb-exporter (percona/mongodb_exporter): richer mongo metrics (replication, per-collection/index stats, query exec, connection pool) on :9216, beyond the basic server status from vector's built-in mongodb_metrics source. URI passed via env, not --mongodb.uri, to keep the password out of the container's process args. - smartctl-exporter: disk SMART health (reallocated sectors, temperature, wear, predicted failure) on :9633, not captured by host_metrics/cadvisor. vector.toml gains prometheus_scrape sources for both and includes them in both OpenObserve remote-write sinks. Also address review feedback: switch redis-exporter depends_on to the list form (no conditional depends_on elsewhere in the repo's compose).
compose resolves `environment:` against the deploy shell and a top-level .env, neither of which carries the provider secrets, so the interpolated REDIS_PASSWORD/MONGODB_URI came out empty and both exporters failed auth.
# Conflicts: # docker/images/vector/src/vector.toml
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opens the work from #2676, which was merged and then backed out of
mainby #3019 so it could go back through review. Same branch, same commits.