Repository navigation
Conversation
AI assistance: OpenAI Codex was used for investigation, implementation, regression tests, and automated validation.
FanWu-ai
marked this pull request as ready for review
October 11, 2026 17:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match.end_nodes() and Match.variables() already decode matched variables, but GrammarCompleter and GrammarValidator unescape those values again. Non-idempotent codecs therefore lose literal backslashes or decode percent sequences twice. This can remove valid completions and give validators different text from the matched argument.
Use each MatchVariable's already-decoded value directly. Keep raw replacement spans and final completion escaping unchanged. Add completion and validation regressions for literal/repeated backslashes, escaped spaces, plain text, and text following the cursor.
Validation on Linux/Python 3.12.14: pristine suite 156 passed; nine regression cases fail on original source; final complete suite 171 passed. Ruff lint/format, typos, strict Mypy for all three configured platforms, all 12 pinned hooks, builds, strict package metadata checks, and diff checks pass. An additional 3,063 shell/URL/JSON codec checks pass. Standard docs build retains two existing mocked-Windows-module warnings.
AI assistance was used to investigate the bug and prepare the implementation and tests. Other native interpreter/OS combinations and hosted checks have not been verified here.