Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 10, 2026 21:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inserting the common prefix of multiple completions rebuilds their Completion objects. That rebuild preserved the display and metadata, but dropped both style and selected_style, so custom menu colors disappeared after Tab.
Forward the two styles when creating the remaining completion. Add a direct regression and a Buffer-level test covering common-prefix insertion and subsequent selection.
Validation on Linux / Python 3.12.14: all 158 tests pass (156 before the change); both new tests fail against the original source. Ruff, formatting, typos, strict mypy for all three configured platforms, all pre-commit hooks, and sdist/wheel builds pass. Hosted CI will be reported separately.
AI assistance was used to prepare the implementation and regression tests.