Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 9, 2026 21:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumberedMargin(display_tildes=True)crashes withUnboundLocalErrorwhen a control returns zero lines of content. This occurs during normalWindow.write_to_screenrendering: the loop never assigns its row index, but tilde filling reads that index afterward.Count displayed rows explicitly and fill the remaining window rows. This also avoids emitting one extra tilde row for nonempty or wrapped content.
The 15 regression cases exercise real window rendering with empty content, left/right margins, relative numbering, tilde-disabled controls, short/full/overflowing content, and wrapped lines. Before the fix, 10 fail and five controls pass; afterward all 15 pass.
Validation on Linux, Python 3.12.14:
git diff --checkpassed.Builds emit the existing setuptools license-classifier deprecation warning. Other Python versions and native operating systems were not run locally. Hosted CI is not claimed as passed.
AI assistance was used to prepare the implementation and regression tests.