Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 9, 2026 21:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HTMLtreats every DOM node other than a text node as an element. Valid comments, processing instructions, and CDATA therefore raiseAttributeErrorwhen their nonexistent attributes are read. For example,HTML('<b>Result: <!-- note --><![CDATA[x < 3]]></b>')cannot be printed.Handle CDATA as text and process attributes/styles only for element nodes. Comments and processing instructions contribute no visible text. Existing nested element styling is preserved.
Ten regressions cover comments at the root and inside styled elements, processing instructions, literal markup in CDATA, mixed node types, restoration of surrounding styles, and actual
print_formatted_textoutput. All ten fail with the original implementation and pass with this change.Validation
On Linux with Python 3.12.14:
git diff --checkpassed.The build reports setuptools' existing deprecated license-classifier warning. Other Python versions and native operating systems were not run locally; the mypy platform checks are static checks. Hosted CI is not claimed as passed.
AI assistance was used to prepare the implementation and regression tests.