Repository navigation
Conversation
\x9b is the C1 form of ESC [, and an argument could set a color.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ANSI("x{}").format("\x9b31mRED")returned RED in ansired.%did the same.\x1b[31mREDwas already a question mark.\x9bis the C1 form of ESC [, andansi_escapeonly replaced\x1band backspace.The argument is now
?31mREDwith no color.ANSI("\x9b32mOK")in the template is still green.Fixes #2113
Test plan
test_ansi_c1_interpolationfails on tip and passes with the extra replacetest_ansi_interpolationandtest_ansi_formattingstill pass