Skip to content

🛡️ Sentinel: Dual Rate Limiting on Auth Server Actions - #116

Open
projectamazonph wants to merge 2 commits into
mainfrom
fix/auth-rate-limit-dual-17185314931449868096
Open

🛡️ Sentinel: Dual Rate Limiting on Auth Server Actions#116
projectamazonph wants to merge 2 commits into
mainfrom
fix/auth-rate-limit-dual-17185314931449868096

Conversation

@projectamazonph

Copy link
Copy Markdown
Owner

Description

This security enhancement implements asynchronous dual rate limiting on sensitive authentication server actions to prevent brute force, event-loop starvation, and Account Lockout Denial of Service (DoS) attacks.

Vulnerability & Threat Model

Previously, signInAction and signUpAction used a standard single-key rate-limiting utility bound exclusively to user emails. An attacker could continuously request actions on a target user's email, filling the rate-limiting buckets and blocking the legitimate user from signing in or completing registration, causing an Account Lockout Denial of Service.

Mitigation & Implementation

  • IP-First Dual Rate Limiting: We created rateLimitDual which retrieves and checks the client IP rate limits (ipLimit defaulting to 20 per 60s) before assessing or incrementing target-based keys (defaulting to 5 per 60s). This prevents an IP-blocked attacker from polluting or locking out a target's bucket.
  • Safe Extraction: Safely parses the X-Forwarded-For header in strict TS environments without indexing errors, falling back to X-Real-IP and 127.0.0.1.
  • Async Headers Compliance: Built to be fully asynchronous to support Next.js 15 asynchronous headers() resolution.
  • Cleanup and Test isolation: Exposed resetRateLimits() helper to clear memory between tests.

Verification

  • Added full unit test coverage under src/lib/__tests__/rate-limit.test.ts checking IP priority evaluation, sliding window, cleanup, and case-insensitivity.
  • Updated src/app/actions/__tests__/auth-actions.test.ts to mock the async headers correctly.
  • All 221 tests pass successfully, with clean lint and typecheck checks.

PR created automatically by Jules for task 17185314931449868096 started by @projectamazonph

Implemented asynchronous dual rate-limiting utility `rateLimitDual` that checks the client IP before checking or incrementing the target email-based key. Integrated it to protect `signUpAction` and `signInAction` endpoints, and added a robust set of unit tests in `src/lib/__tests__/rate-limit.test.ts`.

Co-authored-by: projectamazonph <286085559+projectamazonph@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings August 7, 2026 14:05
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@projectamazonph, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 26 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 39f8b3ca-d104-424d-9bcc-f289d2e6c3d2

📥 Commits

Reviewing files that changed from the base of the PR and between 9d0e0bf and be452f2.

📒 Files selected for processing (6)
  • .jules/sentinel.md
  • package.json
  • src/app/actions/__tests__/auth-actions.test.ts
  • src/app/actions/auth.ts
  • src/lib/__tests__/rate-limit.test.ts
  • src/lib/rate-limit.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

- Implemented asynchronous dual rate-limiting utility `rateLimitDual` to prevent account lockout and credential stuffing DoS.
- Integrated `rateLimitDual` into `signUpAction` and `signInAction` auth actions.
- Added comprehensive unit tests in `src/lib/__tests__/rate-limit.test.ts` and updated auth-action tests.
- Upgraded `packageManager` to stable `pnpm@11.15.0` in `package.json` to resolve the broken `pnpm@11.13.0` installation blocker in CI.

Co-authored-by: projectamazonph <286085559+projectamazonph@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants