fix: Compiling check.go when st.Type is 32-bit - #804
Merged
Merged
Conversation
Notably on s390x st.Type is 32-bit and fails to compile without a cast Signed-off-by: Sertonix <sertonix@posteo.net>
sertonix
requested review from
hallyn,
mikemccracken,
raharper,
rchamarthy,
rchincha,
smoser and
tych0
as code owners
September 30, 2026 13:08
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
===========================================
+ Coverage 12.41% 54.87% +42.45%
===========================================
Files 55 55
Lines 5910 5910
===========================================
+ Hits 734 3243 +2509
+ Misses 5056 2094 -2962
- Partials 120 573 +453 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
Which issue does this PR fix:
Fixes part of #648
What does this PR do / Why do we need it:
Notably on s390x st.Type is 32-bit and fails to compile without a cast
Testing done on this change:
Compiled successfully on Alpine CI including some unit tests: https://gitlab.alpinelinux.org/sertonix/aports/-/jobs/2533134
Automation added to e2e:
none
Will this break upgrades or downgrades?
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.