meta: test the sign-in positively, and say where a run is stuck - #1011
Merged
Conversation
Two faults found driving a real account, both invisible without them: isSignedIn asked for /me and returned "the URL does not say login". A signed-out browser is bounced to facebook.com/, which does not say login either, so a brand-new profile reported as signed in, the sign-in was skipped, and canAdminister then answered false for an app the account actually owns — a wrong answer that looks like a real one. It now requires landing on a profile path with no login form on it. This is the same trap the Google recipe documents; it was repeated here. The sign-in loop also had no progress output, so a stuck run was silent for its whole 55-minute timeout and every wall Meta puts up looked identical from outside. SH1PT_BROWSER_DEBUG now prints the URL and the top of the page each pass, matching the Google recipe. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WYMJH7N4d2qRct5Q5q2YWQ
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
ThreatCrush Security Scan49 finding(s) HIGH/CRITICAL: 1 | MEDIUM: 14 | LOW: 34
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two faults in the
meta-apprecipe from #1010, both found by driving a real account and both invisible without the second fix.isSignedInfalse-positived. It asked for/meand returned "the URL does not say login". A signed-out browser is bounced tofacebook.com/, which does not say login either, so a brand-new profile reported as signed in,signInwas skipped, andcanAdministerthen returnedfalsefor an app the account owns. A wrong answer that looks exactly like a real one. It now requires landing on a profile path with no login form present.This is the same trap the Google recipe already documents in a comment, repeated in the new one.
The sign-in loop was silent. No progress output at all, so a stuck run stayed quiet for its whole 55-minute timeout and every wall Meta raises looked identical from outside.
SH1PT_BROWSER_DEBUGnow prints the URL and the top of the page each pass, matchinggoogle-cloud-oauth.Verified:
tsc --noEmitclean, 27 tests pass across the package.Not verified: a completed sign-in as an app-owning account. The dev box was starved at the time (63 Chrome processes, ~2 GB free, from a parallel test run), and the run made no progress in ten minutes. The recipe is unchanged in behaviour once signed in.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WYMJH7N4d2qRct5Q5q2YWQ