Campaigns from the API fall back to the page's own copy when no model has credit - #237
Merged
Conversation
… has credit generateAdCreatives needs an AI provider with balance; with both providers out, every campaign opened from the API or the CLI failed, so a blog post published through myna ran no ad. templateCopy() writes the creative set from the page's title, description and palette, and createCampaignForUrl uses it when the generator throws. The provider is recorded as template. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YafYxayh7Gqe5MWNNQMev2
ThreatCrush Security Scan39 finding(s) HIGH/CRITICAL: 2 | MEDIUM: 28 | LOW: 9
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #235 (re-cut of #236 on top of master).
createCampaignForUrlfailed on the very first live call: OpenAI has no credits and the Anthropic key is capped until 2026-10-01, sogenerateAdCreativesthrew and the campaign was refused.templateCopy(brand)now writes the creative set from the page's own title, description and palette (og:image as the hero), and the API uses it whenever the generator throws. Provider is recorded astemplate (…). Editable in the dashboard like any generated creative.3 new tests; typecheck clean.
🤖 Generated with Claude Code
https://claude.ai/code/session_01YafYxayh7Gqe5MWNNQMev2