fix(crawlproof): crawlproof update updates it - #58
Merged
Conversation
`/cli-tools crawlproof update` printed the dashboard's usage and exited 2. The wrapper spells its own flags `--self-*` so that every plain word belongs to upstream, which is the right default and was the wrong answer here: `update` is the word `cli-tools update` already uses in this repo, so getting usage back is the command being wrong rather than the person. So the wrapper claims exactly three words -- update, upgrade, self-update -- and only in first position, which keeps `crawlproof ads budget update` upstream's. Installing is the wrapper's job and can never come to mean something in the dashboard, so this is the one place the rule is safe to break. The predicate lives in src/ and is exported, so the tests exercise the real thing rather than a copy of the word list. Note: test/root-ubuntu.test.ts fails on master as of #56, unrelated to this. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HvWJ4336pxTFRdRbvsTQeD
ThreatCrush Security Scan12 finding(s) HIGH/CRITICAL: 4 | MEDIUM: 4 | LOW: 4
Snippets are redacted; ThreatCrush never prints matched credential material. |
This was referenced Sep 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wrapper spells its own flags
--self-*so that every plain word belongs to upstream. That is the right default and it was the wrong answer here:updateis the wordcli-tools updatealready uses in this repo, so typing it and getting the dashboard's usage back is the command being wrong rather than the person.The wrapper now claims exactly three words —
update,upgrade,self-update— and only in first position, socrawlproof ads budget updatestill reaches upstream untouched.This is the one place the rule is safe to break: installing is the wrapper's job and can never come to mean something in the dashboard. The comment says so, next to the exception.
wantsSelfUpdatelives insrc/crawlproof.tsand is exported, so the tests exercise the real predicate rather than a copy of the word list — the first draft of these tests asserted a duplicated constant against itself, which is worse than no test.Verified
Update works, and a plain word still passes straight through.
Heads up: master is red
test/root-ubuntu.test.ts > the groups subcommand > is peeled off before the root checkfails on master as of #56, unrelated to this change — this branch touches onlybin/crawlproof.ts,src/crawlproof.tsandtest/crawlproof.test.ts, while that test readsroot-ubuntu.sh. Everything else is green: 731 passing, 21 in the crawlproof module.🤖 Generated with Claude Code
https://claude.ai/code/session_01HvWJ4336pxTFRdRbvsTQeD