Conversation
# Conflicts: # tests/test_flows.py
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first attempt to add Sylvester Normalizing Flows (van den Berg et al. 2019), and also Planar flows (Rezende et al. 2015), both listed in #28 as requested flow architectures.
The inverse and thus sampling are solved through a bisection method.
I'm open to comments and suggestions! Let me know if anything needs improvement. The part I'm least sure about is the inverse:
I haven't found these issues in practice yet, but I think the code is definitely vulnerable to these