Repository navigation
Build release binaries and the Docker image for the baseline CPU - #204
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release.yml and the Dockerfile ran
zig buildwithout-Dcpu, so Zig compiled for the build machine's own CPU. The v0.9.0 linux-x86_64 binary was built on an AMD runner and contains SSE4ainsertq; on an Intel i9-11900H it dies with SIGILL as soon as the spider opens a TLS connection. Earlier releases and ghcr.io images are built the same way.Both now pass
-Dcpu=baseline, as nix/package.nix and the StartOS package already do.Verified locally: a ReleaseFast
-Dcpu=baselinebuild contains no SSE4a or AVX instructions (the v0.9.0 binary has 2 and 11080), and it ran the spider against three public relays for 4 minutes without crashing. Every one of the 7583 events it stored was by a follow or the admin or p-tagged a follow.