Repository navigation
Conversation
Contributor
Author
|
There was a problem hiding this comment.
🔵 Needs a closer look
Visual verification at 125% and 175% zoom is needed to confirm that the padding resolves the reported clipping.
0 open findings
What changed in this PR
Adds bottom padding to the rendered system bounds to address clipping above 100% zoom reported in #575.
Changes:
- Increases the system rectangle height by 2.0 units.
| File | Description |
|---|---|
| source/painters/systemrenderer.cpp | Adds vertical padding to the system bounds. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
I'm not sure if this completely fixes the issue - I was still able to reproduce the clipping when interactively editing the score. |
Contributor
Author
|
Can you show an example ? Thanks |
Member
|
Sorry, here you go! This was with interactively editing the score to add some notes at the bottom padding.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for zoom > 100%
#575