Skip to content

Fix mobile capsule menu drift during drag - #404

Merged
powerfooI merged 1 commit into
mainfrom
fix/mobile-capsule-drag
Oct 13, 2026
Merged

powerfooI merged 1 commit into
mainfrom
fix/mobile-capsule-drag

Conversation

@powerfooI

Copy link
Copy Markdown
Owner

Summary

  • Keep drag translation on the outer mobile capsules so the terminal, files, and changes buttons stay inside the capsule beside the close button.
  • Move compact controls as one stack without translating nested pills again.
  • Add a regression test against production-built CSS for both normal and compact layouts.

Verification

  • Bun 1.4.3: bun run build:web.
  • bun run precommit --timeout=15000: formatting, lint, complete TypeScript checks, and the full four-worker suite (3527 passed, 3 opt-in skips). Only the local default per-test deadline was raised; no test assertions or project files were changed for validation.
    • Earlier attempts hit the SSH fixture's default 5-second timeout and, in a serialized run, a SQLite error in the Pi SDK fixture. The final four-worker run passed.
  • Chromium mobile touch viewport against an isolated real Roamgate backend: 34 layout checks covering left/right dragging, edge snapping, collapse/expand, 100%/125%/150% UI scale, and normal/compact layouts.
  • Physical iOS Safari and Android Chrome validation is still pending.

No changes to persisted placement, drag event handlers, dependencies, or the backend are included in this PR.

@powerfooI powerfooI added the bug Something isn't working label Oct 13, 2026
@powerfooI

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T06:52:07.371818Z ae347b6 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: ae347b6b76

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@powerfooI
powerfooI merged commit 12c4310 into main Oct 13, 2026
5 checks passed
@powerfooI
powerfooI deleted the fix/mobile-capsule-drag branch October 13, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant