Migrate code signing to the 2026 secrets - #541
Merged
Merged
Conversation
The signing credentials have been re-issued under new `_2026` names, and `SM_CLIENT_CERT_FINGERPRINT` has been replaced by a keypair alias. `signtool /sha1` takes a thumbprint and has no alias form, so signing moves to `smctl sign --keypair-alias`, which no longer needs the certificates synced into the Windows store first. Verification now also checks the signature status, timestamp and signer name. Mirrors posit-dev/assistant#1935.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signing credentials have been re-issued under new
_2026names, andSM_CLIENT_CERT_FINGERPRINThas been replaced by a keypair alias.signtool /sha1takes a thumbprint and has no alias form, so signing moves tosmctl sign --keypair-alias, which no longer needs the certificates synced into the Windows store first. Verification now also checks the signature status, timestamp and signer name.