POK-314: Audit curl-install + npm-version_check agent family for explicit uninstall (qwen, blackbox, amp, continue, openclaw)

[saheljalal]

Closes POK-314

Summary

POK-313 left mimo/omp (later roo/qoder) with explicit uninstalls and a contract test pinning the class. This PR audits the entire curl-install + npm-version_check family by reading each vendor's install script, fixes the remaining members, and adds aikit uninstall --dry-run (named in the issue's acceptance criteria; the flag didn't exist). aikit 2.0.0 → 2.1.0 (MINOR — new flag dominates the PATCH-level fixes).

Audit (AC1 + AC2)

Nine AGENTS entries match (install starts with curl) AND (version_check.type == npm):

Key	What the curl installer actually drops (verified from install.sh)	State before
qwen	Standalone archive → ~/.local/lib/qwen-code/ (self-contained bin/qwen + bundled node runtime), wrapper ~/.local/bin/qwen, writes ~/.qwen/source.json; npm is only the installer's fallback channel	broken — derived npm uninstall -g no-op'd
blackbox	Zip → ~/.blackbox-cli-v2/ with npm deps vendored inside the tree (never a global npm install); wrappers ~/.local/bin/blackbox + blackbox.mjs	broken
amp	Self-contained binary ~/.amp/bin/amp + symlink into ~/.local/bin (or ~/bin, ~/.bin)	broken
continue	install.sh wraps npm install -g @continuedev/cli (may repair npm prefix to ~/.npm-global)	half-broken — npm uninstall correct, but ~/.continue survived
openclaw	install.sh wraps npm install -g openclaw	latent — shim-only uninstall left the npm tree behind
mimo, omp	fixed in POK-313	ok
roo, qoder	fixed previously	ok

Changes (AC3 + AC4)

• qwen_uninstall_cmd, blackbox_uninstall_cmd, amp_uninstall_cmd, openclaw_uninstall_cmd + explicit uninstall_cmd entries; continue gets the jules/codebuff-shaped lambda (npm uninstall -g + rm -rf ~/.continue). Vendor dirs mirror what discover_auth reads (~/.qwen, ~/.blackbox{,-cli-v2,/ai,/cli}, ~/.amp, ~/.config/amp, ~/.continue, …), so uninstall_removes_vendor_data is True for all.
• qoder's conditional npm-channel cleanup factored into _npm_channel_cleanup_cmds() (output-identical) and reused by qwen.
• test_aikit_curl_installed_npm_version_check_agents_have_explicit_uninstall now pins all nine members (with a monkeypatched empty npm-prefix set for determinism) plus the npm-wrapping continue/openclaw sub-family; test_aikit_openclaw_registry_entry updated to the corrected contract (intentional behavior change, documented in-test); the four fixed entries removed from test_aikit_npm_agent_uninstall_derived_from_version_check.
• New aikit uninstall --dry-run (parser + do_uninstall(dry_run=)): prints each resolved command with a vendor-data note, executes nothing, prompts nothing.

Verification (AC5)

$ venv/bin/python -m pytest
601 passed in 11.16s     # baseline was 600

$ ./aikit uninstall --dry-run qwen blackbox amp continue openclaw qoder mimo omp roo
  [1/9] Would uninstall 🐉 Qwen Code (removes vendor config/data)
  rm -f $HOME/.local/bin/qwen /usr/local/bin/qwen ; rm -rf $HOME/.local/lib/qwen-code $HOME/.qwen $HOME/.config/qwen
  … all nine print the real footprints, exit 0

Installer evidence snapshots: qwen (install-qwen-standalone.sh: INSTALL_LIB_DIR=~/.local/lib/qwen-code, install_npm() fallback), blackbox (BLACKBOX_INSTALL_DIR=~/.blackbox-cli-v2, npm ci inside packages/*/dist), amp (AMP_HOME=~/.amp, BIN_DIR symlink), continue (install_cli() → npm install -g "$PACKAGE_NAME"), openclaw (run_npm_global_install → install -g).

Files

• aikit — 4 new uninstall functions + shared helper, 5 registry entries, --dry-run, version bump 2.1.0
• tests/test_tools_characterization.py — family-wide contract test, dry-run test, openclaw contract update
• CHANGELOG.md, docs/aikit.md — 2.1.0 entry, uninstall row documents --dry-run

[saheljalal]

Review — POK-314 (Code Reviewer)

Verdict: Approve — the diff does what the issue asks, is evidence-backed and well tested; findings below are non-blocking. (Submitted as a COMMENT review because GitHub rejects APPROVE from this token identity — "can not approve your own pull request", both agents share the workspace GitHub App.)

Verified independently: family enumeration (computed (install starts with curl) AND version_check.type == npm against the live registry → exactly the nine pinned members, none missed), qwen installer evidence (INSTALL_LIB_DIR=~/.local/lib/qwen-code, wrapper ~/.local/bin/qwen, ~/.qwen/source.json, install_npm() fallback — all covered by the new uninstall), blackbox vendor dirs match discover_auth (~/.blackboxai/~/.blackboxcli), continue's prefix-repair uses persistent npm config set prefix ~/.npm-global so _npm_global_prefixes() detects it, qoder refactor is output-identical, --dry-run smoke for all nine runs clean (exit 0, no prompts/execution), 600 passed + 1 pre-existing env skip locally (tomli_w), CI test green on head, single clean commit, no merge commits.

Should-fix

• tests/test_tools_characterization.py:1050 — family membership is hardcoded; a future curl+npm agent silently escapes the contract (the same drift that let roo/qoder past POK-313's version). Add a dynamic completeness assertion (suggestion inline).

Nit

• aikit:3087 — --dry-run with no agent keys still opens the interactive picker; "prompts nothing" holds only when keys are passed.

Praise

• _npm_channel_cleanup_cmds correctly omits the always-emit fallback npm_uninstall_cmd has — exactly the right semantic split between curl-primary (conditional npm cleanup) and npm-wrapping installers (unconditional removal).
• Monkeypatching _npm_global_prefixes in the contract test keeps it deterministic on machines that happen to have one of these npm-installed.

[saheljalal]

Should-fix (non-blocking): the family membership here is a hardcoded list, so the next curl-installed + npm-version_check agent added to AGENTS silently escapes this contract — exactly how roo/qoder drifted past the POK-313 version of this test and needed a separate fix. A dynamic completeness assertion makes the test fail until a new member is classified:

def _install_cmds(agent):
    ic = agent.get("install", "")
    return [str(c) for c in ic.values()] if isinstance(ic, dict) else [str(ic)]

enumerated = {k for k, a in m.AGENTS.items()
              if any(c.startswith("curl") for c in _install_cmds(a))
              and a.get("version_check", {}).get("type") == "npm"}
assert enumerated == {c[0] for c in cases} | {"continue", "openclaw"}, enumerated

I verified the current registry enumerates to exactly these nine, so this is purely drift protection. Happy to see it as a fast-follow.

[saheljalal]

Nit: aikit uninstall --dry-run with no agent keys still opens the interactive picker (the if not agent_keys: branch below), so "prompts nothing" holds only when keys are passed. Fine if intended (the picker selects what to preview) — if so, consider hinting in the --dry-run help text that keys skip the picker, or auto-previewing all installed agents in dry-run mode.

[saheljalal]

Re-review — POK-314 (Code Reviewer)

Verdict: Approve — both findings addressed as suggested; rebase resolution verified clean. Ready for human merge. (Still a COMMENT review — the shared App token can't approve its own PR.)

Verified independently:

• Should-fix (dynamic family assertion) — tests/test_tools_characterization.py:1060 now recomputes the curl+npm family from the live registry and asserts equality with the pinned nine. I confirmed it actually fires: injecting a fake curl+npm entry into AGENTS breaks the equality ({'fakeagent'}), the clean registry passes.
• Nit (dry-run without keys) — aikit:3090 auto-previews all installed agents instead of opening the picker; help text + docs/aikit.md updated. Smoke: ./aikit uninstall --dry-run </dev/null previews 10 installed agents, exit 0, no picker. Both new tests are meaningful (picker monkeypatched to fail if invoked; none-installed path asserted).
• Rebase onto main's 2.0.1 — version/docstring correctly 2.1.0; CHANGELOG stacks 2.1.0 above 2.0.1; POK-392's change survives intact (print_agent_table still suppresses the collision warning; agent_bin_collision_warnings() def + install/doctor call sites present); PR-vs-main diff contains only POK-314 content.
• Gates — 602 passed + 1 pre-existing env skip (tomli_w) locally, consistent with the reported 603; CI test pass on head b6ccfec; MERGEABLE/CLEAN; single commit, no merge-from-main.

One no-action observation: the changelog now reads 2.1.0 — 2026-09-10 above 2.0.1 — 2026-09-11 (the branch's entry predates main's 2.0.1 landing). Semver order is correct and the dates reflect authoring order — nothing to change, just noting it reads oddly.