[nanddeepn]

Adds 'spo file roleassignment list' command. Closes #6191

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds the ability to list SharePoint file role assignments via a new command and centralizes file/permissions retrieval logic in the spo utility.

Changes:

• Updated SharePoint REST calls to use decodedUrl in GetFolderByServerRelativePath/GetFileByServerRelativePath requests
• Added spo.getFileByUrl() and spo.getFileRoleAssignments() helpers and refactored spo file get to reuse them
• Introduced new spo file roleassignment list command with tests and documentation

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/utils/spo.ts	Adds helper methods for file retrieval and role assignments; updates REST parameter casing
src/utils/spo.spec.ts	Updates URL expectations for decodedUrl and adds tests for new helpers
src/m365/spo/commands/file/file-roleassignment-list.ts	New command to list role assignments for a file by URL or ID
src/m365/spo/commands/file/file-roleassignment-list.spec.ts	Unit tests for the new command behavior and validation
src/m365/spo/commands/file/file-get.ts	Refactors permission retrieval to use shared spo.getFileRoleAssignments()
src/m365/spo/commands/file/file-get.spec.ts	Updates tests to stub spo.getFileRoleAssignments()
src/m365/spo/commands.ts	Registers new command constant
docs/src/config/sidebars.ts	Adds the new command doc to the sidebar
docs/docs/cmd/spo/file/file-roleassignment-list.mdx	Adds documentation page for the new command

[milanholemans]

Thanks, we'll try to review it ASAP!

[MartinM85]

Hi @nanddeepn, could you please check the findings from Copilot? Thank you

[nanddeepn]

Hi @MartinM85
Done

[MartinM85]

Thank you for the contribution @nanddeepn 🚀
Looks good overall, just a few tiny things to consider. One major thing is to use the Zod schema for command options, but our AI skill can help you save a time.

[MartinM85]

Hi @nanddeepn, thank you for the contribution 🚀
Only one note from my side regarding the text output. As Copilot noticed, the doc has missing Permissions section.

[MartinM85]

Approved. I will merge it later.

[Copilot]

🟡 Changes recommended

Active issues remain: the documentation sample does not match the command’s actual text output order, and the new helper uses untyped responses that weaken compile-time validation of the mapped role-assignment fields.

1 open issue

• Correct text output property order · New

2 resolved since last review

• Flatten nested role-assignment fields for text output
• Add required Permissions section to command documentation

_{Review effort: Lite}

[Copilot]

🔵 Needs a closer look

The new public utility exposes any in its return type and response payload, removing type safety where existing RoleAssignment and RoleDefinition types could be used instead.

No open issues 🎉

1 resolved since last review

• Correct text output property order

_{Review effort: Lite}