test: add unit tests for relative_import - #5663
Merged
Merged
Conversation
Contributor
|
Thanks for the PR! I'll review it and follow up. |
camdecoster
requested changes
Jul 30, 2026
camdecoster
left a comment
camdecoster
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Before I merge, could you please move the file to tests/test_plotly_utils? That seems more appropriate.
Address review feedback: relocate the importers unit tests from tests/test_core/test_utils/ to tests/test_plotly_utils/, which is the more appropriate location for _plotly_utils tests. No test changes; the import is absolute, so the move is behavior-preserving.
Contributor
Author
|
Done, moved it to |
Contributor
Author
|
Hi @camdecoster, gentle follow-up - the file's been moved to |
camdecoster
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
_plotly_utils.importers.relative_importis the helper behind plotly's lazysubmodule imports - it returns the
(__all__, __getattr__, __dir__)triple apackage assigns to enable PEP 562 lazy loading. It had no test coverage.
This adds
tests/test_core/test_utils/test_importers.pycovering:__all__listing the leaf names of the requested modules and classes__getattr__lazily importing a submodule__getattr__lazily importing a class off a submodule__getattr__raisingAttributeErrorfor an unknown name__dir__returning__all__The tests use the stdlib
collectionspackage as a stable lazy-import target,so they don't depend on plotly's own module layout. No source changes.
Verification
pytest tests/test_core/test_utils/test_importers.py- 5 passed.ruff check/
ruff format --checkclean.