Skip to content

fix(service): isolate npm cache for installed LaunchAgents - #215

Merged
pitimon merged 3 commits into
mainfrom
fix/launchagent-npm-cache
Oct 18, 2026
Merged

pitimon merged 3 commits into
mainfrom
fix/launchagent-npm-cache

Conversation

@pitimon

@pitimon pitimon commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Purpose: make installed service configuration reproduce the dedicated npm cache used to recover 0.39.58 activation. Update both independent readers/writers without clearing the user's existing cache or changing token collection semantics.

Patch prepared against base 33c87e505775785a02620a607839be85b65109f4, branch fix/launchagent-npm-cache, preserved locally as a patch receipt:

  • Changes the owning installer for both LaunchAgents, sets their shared dedicated cache, and XML-escapes HOME-derived paths.
  • Real installer test runs in a disposable HOME with fake launchctl; tests ordinary and spaces/XML-sensitive HOME paths, two consecutive installs, exact package pin, cache-content retention and generated-wrapper shell syntax.
  • Implementer observed RED (dashboard missing dedicated npm cache), then reports 22 focused tests passing. Parent separately inspected the complete diff and reran node --test test/release-automation.test.js: 8 passed, 0 failed, 0 skipped on macOS. Parent also ran bash -n scripts/install-local-service.sh and git diff --check, both passed.
  • No real launchctl activation, credentials, queues or shared npm cache touched. At the local-preparation stage there was no version bump or source commit/push; the reviewed patch is now committed and pushed at 88e1a08.
  • Limitations: full CI not run; the execution regression is macOS-only and is skipped on the current Linux hosted jobs. Fake launchctl proves generated configuration, not real service activation. A macOS release check must execute this regression rather than relying on Linux green alone.

No release version chosen yet; any shipped installer change needs the normal version bump, full CI, review and publication gate. This draft PR is not release approval.

Refs #214. Draft: release version selection, full CI and independent review remain before merge readiness. Current services remain on 0.39.58.

@pitimon
pitimon marked this pull request as ready for review October 18, 2026 01:11
@pitimon
pitimon merged commit 8e1c276 into main Oct 18, 2026
2 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T01:11:52.952315Z 9c6309a Draft marked ready
🔒 Security Review ✅ Completed 2026-10-18T01:12:19.931711Z 9c6309a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant