Skip to content

fix(web): keep branchless thread cards full height #25716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PixPMusic wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −8
Open

fix(web): keep branchless thread cards full height #25716

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9dc1af
fix(web): keep branchless thread cards full height
PixPMusic Oct 27, 2026
8a8dc42
merge: bring current main into branchless card fix
maria-rcks Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions apps/web/src/components/sidebar/SidebarThreadRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1129,8 +1129,9 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: SidebarThreadRowP
</span>
) : null;
const diff = latestRunDiff(thread);
// Only the trailing icons would remain, so the row moves them to the title line instead.
// Compact rows move trailing icons to the title when no other metadata remains.
const metaLineEmpty =
variant !== "card" &&
!thread.branch &&
!showsScratchMachine &&
prBadge === null &&
Expand Down Expand Up @@ -1392,7 +1393,6 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: SidebarThreadRowP
{...(fileDropHandlers ?? {})}
className={cn(
"list-none py-0.5 [content-visibility:auto] [contain-intrinsic-size:auto_78px]",
metaLineEmpty && "[contain-intrinsic-size:auto_58px]",
sortable?.isDragging && "relative z-20",
)}
>
Expand All @@ -1418,12 +1418,7 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: SidebarThreadRowP
}
>
{accessibleTitle}
<div
className={cn(
"relative z-10 h-[4.875rem] px-(--sidebar-row-content-inset) py-(--sidebar-content-inset)",
metaLineEmpty && "h-auto",
)}
>
<div className="relative z-10 h-[4.875rem] px-(--sidebar-row-content-inset) py-(--sidebar-content-inset)">
<div className="flex h-5 min-w-0 items-center gap-1.5">
{draftIndicator}
{props.project ? (
Expand Down
Loading