Repository navigation
fix(deps): update packages with high and critical security advisories - #23906
DragonVibes wants to merge 2 commits into
Conversation
osv-scanner reported 13 high or critical advisories in pnpm-lock.yaml on main. This moves every one that has a fixed release onto it: - @modelcontextprotocol/sdk 1.29.0 -> 1.32.0 (server, GHSA-22jm-h49p-29qw) - dompurify 3.4.16 -> 3.4.17 (web, GHSA-cg2g-xh64-v4q7) - sharp 0.35.4 -> 0.35.5 (marketing and scripts, GHSA-wq5f-xc86-pv6w) - seroval 1.5.4 -> 1.7.0 (TanStack Router, GHSA-p6vx-979v-rg4c) - shell-quote 1.10.0 -> 1.12.0 (react-devtools-core, GHSA-pqg4-j6r4-53mv) - proxy-addr 2.0.7 -> 2.0.8 (express, GHSA-jqcg-44mw-7w3h) - source-map-js 1.2.1 -> 1.2.2 (magicast, GHSA-68fv-2mgg-jv7q) - path-to-regexp 6.1.0 -> 6.3.0 (@vercel/routing-utils, GHSA-9wv6-86v2-598j) The transitive bumps stay inside their parents' ranges. The exception is @vercel/routing-utils, which pins path-to-regexp 6.1.0 exactly, so it gets an override. Still open: braces, node-forge and http-cache-semantics have no fixed release, and uuid 7.0.3 under Expo's xcode needs a major bump. Done with Claude Opus 5.5 in Claude Code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR requires human approval — This is a focused dependency and lockfile update with no product-default or application-logic changes, but it directly remediates high and critical security advisories across server, web, routing, and image-processing paths. The security-sensitive purpose warrants human review. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Dependency versions and resolution apps/marketing/package.json, apps/server/package.json, apps/web/package.json, scripts/package.json, pnpm-workspace.yaml |
Updates sharp to 0.35.5 in marketing and scripts, @modelcontextprotocol/sdk to 1.32.0, and dompurify to ^3.4.17. Adds an override that resolves path-to-regexp under @vercel/routing-utils to 6.3.0. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Other
Possibly related issues
- [Bug]: 12 packages in pnpm-lock.yaml have high or critical security advisories #23907: The issue describes updates to advisory-affected packages, including packages and the
path-to-regexpoverride changed here.
Possibly related PRs
- pingdotgg/t3code#24913: Updates
dompurifyfrom3.4.16to3.4.17, matching an update in this pull request, and includes related dependency fixes. - pingdotgg/t3code#23988: Adds validation for dependency inputs changed in this pull request.
Suggested reviewers: t3dotgg
Merge Risk: 
Minimal · up to 6c422
-
The dependency updates are ready to merge based on the reviewed evidence.
Pre-merge checks: 
4
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
…isories Rebuilt pnpm-lock.yaml from main's copy with this branch's manifest and override changes, then dropped the sharp 0.35.4 entries that nothing references any more. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Problem
osv-scanneronpnpm-lock.yamlatmainreports high or critical advisories in 7 packages that have a fixed release in the same major version. A dependency update removes them.Change
@modelcontextprotocol/sdkgoes from 1.29.0 to 1.32.0 inapps/server, anddompurifyfrom 3.4.16 to 3.4.17 inapps/web.sharpgoes from 0.35.4 to 0.35.5 inapps/marketingandscripts.seroval,shell-quote, andproxy-addrinside their parents' existing ranges. This changes the lockfile only.pnpm-workspace.yaml.@vercel/routing-utilspinspath-to-regexp6.1.0 exactly, even in its latest release, so the override moves it to 6.3.0.The lockfile changes only these packages and sharp's platform binaries. The
vitestsnapshot entries also gain peer metadata, because anypnpm updatere-reads it. No version changes there.Scope and approval
Refs #23907, which lists every advisory with its CVE and where T3 Code uses the package.
mainhas since fixedsource-map-jsandbraces.This is maintenance with no change to product behavior, and every bump is a patch or minor release. It fixes one problem: dependencies with published advisories. The advisories are public, so this uses a normal PR rather than the private security address.
Out of scope:
node-forgeandhttp-cache-semanticshave no fixed release yet.uuid7.0.3 under Expo'sxcodeneeds a major bump. Advisories published after this PR opened, inbody-parser,undici, andzod, belong in their own PR.Verification
osv-scanner: 17 high or critical packages on currentmain, 10 on this branch. All 10 are in the out-of-scope list above.apps/server:tsc --noEmitis clean.vp test runon the Claude adapter, provider, MCP app, MCP OAuth, and HTTP tests passes 296 of 296. A script ran a tool call throughcreateSdkMcpServerfrom@anthropic-ai/claude-agent-sdk, which is the SDK's only consumer, on MCP SDK 1.32.0.apps/web:tsc --noEmitis clean andvp buildsucceeds. A local browser test rendered a real flowchart and a math diagram through both DOMPurify sanitizers inMermaidDiagram.tsx. The test failed when I made the sanitizer striptextormsup. The test is not in this PR because nothing in the repo currently covers those sanitizers, and that is a separate problem.apps/marketing:astro buildsucceeds and writes.webpimages throughsharp0.35.5.scriptsand alchemy's Cloudflare runtime both load the same singlesharp0.35.5.vercel.tsconfigs give identicalgetTransformedRoutesoutput withpath-to-regexp6.1.0 and 6.3.0.Not checked: desktop and mobile builds, and a real alchemy or Vercel deploy.
Done with Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code