Repository navigation
fix(client-runtime): recover threads when resume never completes #20932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JustYannicc
wants to merge
339
commits into
pingdotgg:main
Choose a base branch
from
JustYannicc:fix/resume-completion-deadline-upstream
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+453
−29
Open
Changes from all commits
Commits
Show all changes
339 commits
Select commit
Hold shift + click to select a range
a2c71d7
Merge commit '5c3721e20aa3c19d7ab414c40734752f9c053c90' into babysit/…
JustYannicc 674e9a4
Merge commit '968dd51704441138559a3fe9c348719f2b11e0c6' into babysit/…
JustYannicc f14388f
Merge commit '1befc717f0b277c86a066e46598e60465e7f23c2' into babysit/…
JustYannicc a71f987
Merge commit 'a12d6ed9428d8e64d76ca86d178abbf564b57cee' into babysit/…
JustYannicc 77c2196
Merge commit 'b5a226e49c52ecab4ddc2d678a7012d97e651a6a' into babysit/…
JustYannicc b475c52
Merge commit 'ed9b7ca9c53843ea1e6b466bf7d52928d10e7db0' into babysit/…
JustYannicc 849aee6
Merge commit '89fe509232e787b51d0cf695861afe73316ce85b' into babysit/…
JustYannicc 488913a
Merge commit 'f8e4834861d255f58c44fc1b5f57c34c49f5384d' into babysit/…
JustYannicc 0480330
Merge commit 'aa0158d0d3099bada270b059b7ca7226a547bea1' into babysit/…
JustYannicc 6875ba5
Merge commit 'defb7e6e6b87d03259745367214db13060fb322b' into babysit/…
JustYannicc 91aab3e
Merge commit '3690c862530c88781b28dce991697e5ea0dc26be' into babysit/…
JustYannicc aa7e9e5
Merge commit '05b697f6a2012497ae790425e197fbd1fcef7de7' into babysit/…
JustYannicc 7cf81b0
Merge commit 'e07595714a467e18c750107137d2c2e50f0c3530' into babysit/…
JustYannicc 79637f7
Merge commit '6f75bcb374c0e19ff90e4f7c2d3949c58aba5f02' into babysit/…
JustYannicc 03c1a4b
Merge commit '3b95e7831b11b17627dff16843bc087bfca397ec' into babysit/…
JustYannicc 635caf0
Merge commit '96bae5465bc5dfaedc890998a7a71672fb470ae2' into babysit/…
JustYannicc c8bb9ae
Merge commit 'ee33c4c65dfde09564c2c9f9da4ffdf53828cb15' into babysit/…
JustYannicc 2b03002
Merge commit 'ff525478e236ec0df4c4920eb03ac3961ea714a2' into babysit/…
JustYannicc f088d7a
Merge commit '8d3b061121fe65669d5d43d011b48cd3027a4108' into babysit/…
JustYannicc 47d9f9b
Merge commit '60b35a1ee02d717009ff4a3de34de285db9e8a60' into babysit/…
JustYannicc 617d13a
Merge commit 'f460ddb23a49e459575f6dbcc0101212d8640a2e' into babysit/…
JustYannicc 899f0d9
Merge commit '4eae8ae011e2e56ca20159c13f3fb8a2ac49a991' into babysit/…
JustYannicc a2de720
Merge commit '044f07257c9684ae4543bd1e1ebf9c394e9e3830' into babysit/…
JustYannicc 246551d
Merge commit 'ef92441313da327139df75daa8f723c0f42348f6' into babysit/…
JustYannicc 42364e1
Merge commit '2c8bdf6177159d8fcd12a897d7c9311f6eb93237' into babysit/…
JustYannicc cb594f8
Merge commit '11adcb0e25a04785f70d01c3f2a858889683007e' into babysit/…
JustYannicc aba8fd7
Merge commit '200dad3b39aa9c2562b4bae54106ab8acdcc4163' into babysit/…
JustYannicc 35259d6
Merge commit 'f5cf9a02de10fa61ef180020a607279351c8b4cb' into babysit/…
JustYannicc b243e07
Merge commit '23bd753806eb9db5a315fbf9ac6563d355f20b3a' into babysit/…
JustYannicc 2afcd80
Merge commit '51273020db3245f4ec29514a419d29b5dcb012dc' into babysit/…
JustYannicc bec1961
Merge commit '18e27425195686a5215fdc2cfa2bca088cdb8972' into babysit/…
JustYannicc a8efed1
Merge commit '50e151c7a41460649ad7e63acbb00c03e5175c18' into babysit/…
JustYannicc 0b119f1
Merge commit 'a8dba9ca93ab0541871b50dc8448e0c741b1cad0' into babysit/…
JustYannicc 7b9bb63
chore: merge upstream main into resume recovery branch
JustYannicc ad07922
chore: merge upstream main into resume recovery branch
JustYannicc 897947b
chore: merge upstream main into resume recovery branch
JustYannicc 09e02f8
chore: merge upstream main into resume recovery branch
JustYannicc e8fb8ce
chore: merge upstream main into resume recovery branch
JustYannicc edbca58
chore: merge upstream main into resume recovery branch
JustYannicc c1f4faa
chore: merge upstream main into resume recovery branch
JustYannicc b617848
chore: merge upstream main into resume completion deadline
JustYannicc 5e35291
chore: merge upstream main into resume completion deadline
JustYannicc 273df54
chore: merge upstream main into resume completion deadline
JustYannicc d72fb5a
chore: merge upstream main into resume completion deadline
JustYannicc d998959
chore: merge upstream main into resume completion deadline
JustYannicc 97081b6
chore: merge upstream main into resume completion deadline
JustYannicc 1a2e69d
chore: merge upstream main into resume completion deadline
JustYannicc 1be0073
chore: merge upstream main into resume completion deadline
JustYannicc 6bd7de8
chore: merge upstream main into resume completion deadline
JustYannicc 20c2ea9
chore: merge upstream main into resume completion deadline
JustYannicc a767949
chore: merge upstream main into resume completion deadline
JustYannicc 0d62044
chore: merge upstream main into resume completion deadline
JustYannicc cf294bc
chore: merge upstream main into resume completion deadline
JustYannicc df10c65
chore: merge upstream main into resume completion deadline
JustYannicc 82243f3
chore: merge upstream main into resume completion deadline
JustYannicc 979c7df
chore: merge upstream main into resume completion deadline
JustYannicc 0c775b3
chore: merge upstream main into resume completion deadline
JustYannicc c98acaf
chore: merge upstream main into resume completion deadline
JustYannicc 526d8ab
Merge upstream main into resume completion deadline fix
JustYannicc 14d4c91
Merge upstream main into resume completion deadline fix
JustYannicc 8c60f79
Merge upstream main into resume completion deadline fix
JustYannicc 40193ad
Merge upstream main into resume completion deadline fix
JustYannicc c1c0dad
Merge upstream main into resume completion deadline fix
JustYannicc 58426e8
Merge upstream main into resume completion deadline fix
JustYannicc 3b59187
Merge upstream main into resume completion deadline fix
JustYannicc b62a6f6
Merge upstream main into resume completion deadline fix
JustYannicc 4bdb66e
Merge upstream main into resume completion deadline fix
JustYannicc d3b2e0e
Merge upstream main into resume completion deadline fix
JustYannicc 53ec2f2
Merge upstream main into resume completion deadline fix
JustYannicc 9ea0b8b
Merge upstream main into resume completion deadline fix
JustYannicc 481fa68
Merge upstream main into resume completion deadline fix
JustYannicc ec981ed
Merge upstream main into resume completion deadline fix
JustYannicc b3348af
Merge upstream main into resume completion deadline fix
JustYannicc 37305ab
Merge upstream main into resume completion deadline fix
JustYannicc f2176c3
Merge upstream main into resume completion deadline fix
JustYannicc 3bb25e9
Merge upstream main into resume completion deadline fix
JustYannicc 3704405
Merge upstream main into resume completion deadline fix
JustYannicc 14ff6ef
Merge upstream main into resume completion deadline fix
JustYannicc a7ef887
Merge upstream main into resume completion deadline fix
JustYannicc 6744d54
Merge upstream main into resume completion deadline fix
JustYannicc e630678
Merge upstream main into resume completion deadline fix
JustYannicc 28261e5
Merge upstream main into resume completion deadline fix
JustYannicc 5959fcb
Merge upstream main into resume completion deadline fix
JustYannicc b2b536b
Merge upstream main into resume completion deadline fix
JustYannicc 2e34395
Merge upstream main into resume completion deadline fix
JustYannicc 7c87584
Merge upstream main into resume completion deadline fix
JustYannicc 1330506
Merge upstream main into resume completion deadline fix
JustYannicc a4e25c3
Merge upstream main into resume completion deadline fix
JustYannicc 3f813e6
Merge upstream main into resume completion deadline fix
JustYannicc 385ef66
Merge upstream main into resume completion deadline fix
JustYannicc 9303ee6
Merge upstream main into resume completion deadline fix
JustYannicc 4853553
Merge upstream main into resume completion deadline fix
JustYannicc b739900
chore: merge upstream main into resume recovery branch
JustYannicc fe89620
chore: merge upstream main into resume recovery branch
JustYannicc d48bedd
chore: merge upstream main into resume recovery branch
JustYannicc b948b8e
chore: merge upstream main into resume recovery branch
JustYannicc 874a119
chore: merge upstream main into resume recovery branch
JustYannicc 4c76218
chore: merge upstream main into resume recovery branch
JustYannicc 05ef8f7
chore: merge upstream main into resume recovery branch
JustYannicc 4406677
chore: merge upstream main and resolve sync test conflict
JustYannicc 4de72ca
chore: merge upstream main into resume recovery branch
JustYannicc fb12ddf
chore: merge upstream main into resume recovery branch
JustYannicc a82e809
chore: merge upstream main into resume recovery branch
JustYannicc 2762749
chore: merge upstream main into resume recovery branch
JustYannicc c7ec0c7
chore: merge upstream main into resume recovery branch
JustYannicc 66d7b5b
chore: merge upstream main into resume recovery branch
JustYannicc 59018e1
chore: merge upstream main into resume recovery branch
JustYannicc 722ebc8
chore: merge upstream main into resume recovery branch
JustYannicc 582b017
chore: merge upstream main into resume recovery branch
JustYannicc 9b3f115
chore: merge upstream main into resume recovery branch
JustYannicc 0f07217
chore: merge upstream main into resume recovery branch
JustYannicc 4da6718
chore: merge upstream main into resume recovery branch
JustYannicc f2a0466
chore: merge upstream main into resume recovery branch
JustYannicc 4d8d7d1
chore: merge upstream main into resume recovery branch
JustYannicc 47ad3b5
chore: merge upstream main into resume recovery branch
JustYannicc ae574f9
chore: merge upstream main into resume recovery branch
JustYannicc cc4742a
chore: merge upstream main into resume recovery branch
JustYannicc 475a0eb
chore: merge upstream main into resume completion fix
JustYannicc 704a5f1
chore: merge upstream main into resume completion fix
JustYannicc 46ccb18
chore: merge upstream main into resume completion fix
JustYannicc a4e1966
chore: merge upstream main into resume completion fix
JustYannicc 98d9f45
chore: merge upstream main into resume completion fix
JustYannicc 1b708ac
chore: merge upstream main into resume completion fix
JustYannicc 56bc794
chore: merge upstream main into resume completion fix
JustYannicc 5669c88
chore: merge upstream main into resume completion fix
JustYannicc 143b43d
chore: merge upstream main into resume completion fix
JustYannicc 6d5799c
chore: merge upstream main into resume completion fix
JustYannicc fe6f1fc
chore: merge upstream main into resume completion fix
JustYannicc 0f48504
chore: merge upstream main into resume completion fix
JustYannicc 7e7c4e7
chore: merge upstream main into resume completion fix
JustYannicc c956339
chore: merge upstream main into resume completion fix
JustYannicc cc78f15
chore: merge upstream main into resume completion fix
JustYannicc 26269fe
chore: merge upstream main into resume completion fix
JustYannicc 911cb56
chore: merge upstream main into resume completion fix
JustYannicc 33ef1a2
chore: merge upstream main into resume completion fix
JustYannicc 8e2e744
chore: merge upstream main into resume completion fix
JustYannicc 60d43f2
chore: merge upstream main into resume completion fix
JustYannicc e6fb1cf
Merge upstream main into fix/resume-completion-deadline-upstream
JustYannicc d861eab
Merge upstream main into fix/resume-completion-deadline-upstream
JustYannicc 8dd63c0
Merge upstream main into fix/resume-completion-deadline-upstream
JustYannicc 5cae5f1
Merge upstream main into fix/resume-completion-deadline-upstream
JustYannicc 19685cf
Merge upstream main into fix/resume-completion-deadline-upstream
JustYannicc 1b76935
Merge upstream main into fix/resume-completion-deadline-upstream
JustYannicc ea26c48
Merge upstream main into fix/resume-completion-deadline-upstream
JustYannicc 792d322
Merge upstream main into fix/resume-completion-deadline-upstream
JustYannicc 94cb565
Merge upstream main into fix/resume-completion-deadline-upstream
JustYannicc 7c73072
Merge upstream main into fix/resume-completion-deadline-upstream
JustYannicc af0e6d3
Merge upstream main into fix/resume-completion-deadline-upstream
JustYannicc 51e416a
Merge upstream main into fix/resume-completion-deadline-upstream
JustYannicc 3b9f5b3
Merge upstream main into fix/resume-completion-deadline-upstream
JustYannicc 868fabc
Merge upstream main into fix/resume-completion-deadline-upstream
JustYannicc 2490309
Merge upstream main into fix/resume-completion-deadline-upstream
JustYannicc 3b2f704
Merge upstream main into fix/resume-completion-deadline-upstream
JustYannicc 26dbb80
Merge upstream main into fix/resume-completion-deadline-upstream
JustYannicc 5554f2c
Merge upstream main into fix/resume-completion-deadline-upstream
JustYannicc 37b5247
Merge upstream main into fix/resume-completion-deadline-upstream
JustYannicc 988acd6
Merge upstream main into fix/resume-completion-deadline-upstream
JustYannicc 02f09ed
Merge upstream main into fix/resume-completion-deadline-upstream
JustYannicc 28cbc3b
Merge upstream main into fix/resume-completion-deadline-upstream
JustYannicc 0a5e4e2
Merge upstream main into fix/resume-completion-deadline-upstream
JustYannicc 6a45820
chore: merge upstream main into resume recovery
JustYannicc c9ace7f
chore: merge upstream main into resume recovery
JustYannicc 66fcaef
chore: merge upstream main into resume recovery
JustYannicc c63ee38
chore: merge upstream main into resume recovery
JustYannicc 77619cc
chore: merge upstream main into resume recovery
JustYannicc f45e319
chore: merge upstream main into resume recovery
JustYannicc 544fa37
chore: merge upstream main into resume recovery
JustYannicc f840a53
chore: merge upstream main into resume recovery
JustYannicc 8c0808f
chore: merge upstream main into resume recovery
JustYannicc 6ba3289
chore: merge upstream main into resume recovery
JustYannicc 3bfe20f
chore: merge upstream main into resume recovery
JustYannicc 3ac8e38
chore: merge upstream main into resume recovery
JustYannicc 8e58a06
chore: merge upstream main into resume recovery
JustYannicc b1bffff
chore: merge upstream main into resume recovery
JustYannicc cd8aea2
chore: merge upstream main into resume recovery
JustYannicc 63824b9
chore: merge upstream main into resume recovery
JustYannicc b2bd636
chore: merge upstream main
JustYannicc 9168c94
chore: merge upstream main
JustYannicc 3ae3d9a
chore: merge upstream main
JustYannicc b089ca3
chore: merge upstream main
JustYannicc a9eef61
chore: merge upstream main
JustYannicc 8d31dc6
chore: merge upstream main
JustYannicc 9a88d03
chore: merge upstream main
JustYannicc 5502e61
chore: merge upstream main
JustYannicc bf1c932
chore: merge upstream main
JustYannicc a3c392c
chore: merge upstream main
JustYannicc 98c3410
chore: merge upstream main
JustYannicc c234844
chore: merge upstream main
JustYannicc cb1e597
chore: merge upstream main
JustYannicc e709bb0
chore: merge upstream main
JustYannicc 098a7f6
chore: merge upstream main
JustYannicc 58b472b
chore: merge upstream main
JustYannicc 712af3a
chore: merge upstream main
JustYannicc ea0c143
chore: merge upstream main
JustYannicc 061ef9d
chore: merge upstream main
JustYannicc 85c2973
chore: merge upstream main
JustYannicc 59e3b55
chore: merge upstream main
JustYannicc 451c673
chore: merge upstream main
JustYannicc 4a0b4b5
chore: merge upstream main into resume recovery branch
JustYannicc c90ed2b
chore: merge upstream main into resume recovery branch
JustYannicc a18a8ae
chore: merge upstream main into resume recovery branch
JustYannicc fa17ffe
chore: merge upstream main into resume recovery branch
JustYannicc 8d4924b
chore: merge upstream main into resume recovery branch
JustYannicc 5030a0d
chore: merge upstream main into resume recovery branch
JustYannicc 205adef
chore: merge upstream main into resume recovery branch
JustYannicc 8781492
chore: merge upstream main into resume recovery branch
JustYannicc 85653d5
chore: merge upstream main into resume recovery branch
JustYannicc 5a6744d
chore: merge upstream main into resume recovery branch
JustYannicc 0197305
chore: merge upstream main into resume recovery branch
JustYannicc 0a1fbd1
chore: merge upstream main into resume recovery branch
JustYannicc 29c4c04
chore: merge upstream main into resume recovery branch
JustYannicc 9020a33
chore: merge upstream main into resume recovery branch
JustYannicc c3e71de
chore: merge upstream main into resume recovery branch
JustYannicc ba626c8
chore: merge upstream main into resume recovery branch
JustYannicc 4c76dce
chore: merge upstream main into resume recovery branch
JustYannicc 7070100
chore: merge upstream main into resume recovery branch
JustYannicc 05de668
chore: merge upstream main into resume recovery branch
JustYannicc c868de5
chore: merge upstream main into resume recovery branch
JustYannicc f04df51
chore: merge upstream main into resume recovery branch
JustYannicc 83afc72
chore: merge upstream main
JustYannicc d6ec015
chore: merge upstream main
JustYannicc f3744eb
chore: merge upstream main
JustYannicc b1c0a2d
chore: merge upstream main
JustYannicc 8487871
chore: merge upstream main
JustYannicc 7911b37
chore: merge upstream main
JustYannicc 085575b
chore: merge upstream main
JustYannicc bb041d0
chore: merge upstream main
JustYannicc 4e25612
chore: merge upstream main
JustYannicc 8b31571
chore: merge upstream main
JustYannicc b9f0e69
chore: merge upstream main
JustYannicc f7f96b7
chore: merge upstream main
JustYannicc 3b50fdf
chore: merge upstream main
JustYannicc f5ba1b6
chore: merge upstream main
JustYannicc 0fdf4b5
chore: merge upstream main
JustYannicc 6695cbc
chore: merge upstream main
JustYannicc 368d5c7
chore: merge upstream main into resume completion deadline
JustYannicc ea86df7
chore: merge upstream main into resume completion deadline
JustYannicc 7ad3394
chore: merge upstream main into resume completion deadline
JustYannicc 16aa7d6
chore: merge upstream main into resume completion deadline
JustYannicc ea80a4d
chore: merge upstream main into resume completion deadline
JustYannicc 4f3cc95
chore: merge upstream main into resume completion deadline
JustYannicc 5ee93d2
chore: merge upstream main into resume completion deadline
JustYannicc 9d5e668
chore: merge upstream main into resume completion deadline
JustYannicc 6910205
chore: merge upstream main into resume completion deadline
JustYannicc 8ace807
chore: merge upstream main into resume completion deadline
JustYannicc 25da121
chore: merge upstream main into resume completion deadline
JustYannicc 2bf04a1
chore: merge upstream main into resume completion deadline
JustYannicc 7872537
chore: merge upstream main into resume completion deadline
JustYannicc 848a0d0
chore: merge upstream main into resume completion deadline
JustYannicc 0c6f5a7
chore: merge upstream main into resume completion deadline
JustYannicc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import { describe, expect, it } from "vite-plus/test"; | ||
|
|
||
| import { resolveThreadSyncPhase } from "./threadSync"; | ||
|
|
||
| describe("resolveThreadSyncPhase", () => { | ||
| it("stops syncing cached detail on terminal error and resumes when recovery clears it", () => { | ||
| const cachedDetail = { | ||
| detailExists: true, | ||
| shellExists: true, | ||
| status: "cached" as const, | ||
| detailError: null, | ||
| }; | ||
| expect(resolveThreadSyncPhase(cachedDetail)).toBe("syncing"); | ||
|
|
||
| const failedDetail = { | ||
| ...cachedDetail, | ||
| detailError: | ||
| "Message synchronization timed out. Reconnect or return to the app to try again.", | ||
| }; | ||
| expect.soft(resolveThreadSyncPhase(failedDetail)).toBeNull(); | ||
|
|
||
| const recoveringDetail = { | ||
| ...failedDetail, | ||
| status: "synchronizing" as const, | ||
| detailError: null, | ||
| }; | ||
| expect(resolveThreadSyncPhase(recoveringDetail)).toBe("syncing"); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.