Repository navigation
Conversation
Replace affected DOMPurify, fast-uri, KaTeX, seroval, shell-quote, and undici resolutions. Cover transitive and mobile Markdown copies, while keeping undici on its existing major lines.
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR requires human approval — This dependency remediation changes runtime sanitization, Markdown/math rendering, HTTP, serialization, and other transitive behavior across web, server, and mobile paths. Its explicit security-advisory scope and broad overrides warrant human review despite the absence of application-source changes. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Web dependencies and workspace resolutions apps/web/package.json, pnpm-workspace.yaml |
The web package updates dompurify to ^3.4.17 and katex to ^0.18.2. The workspace updates the undici catalog version to 8.12.2 and adds overrides for fast-uri, katex, seroval, shell-quote, and undici versions ^6 and ^7. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Other
Possibly related issues
pingdotgg/t3code#23907— The issue reports vulnerable resolutions fordompurify,seroval, andshell-quote. This pull request updates those dependency versions or overrides.
Suggested reviewers: yash-singh1, juliusmarminge
Merge Risk: 
Minimal · up to 06098
-
The dependency updates are mergeable with no identified actionable risk.
Pre-merge checks: 
3 · 
1
-
Failed checks: 1 warning Passed checks: 3 passed-
Full details: Title check
-
Explanation
The title "fix(deps): patch known dependency advisories" follows conventional commit form and names the main change. The changeset updates DOMPurify, fast-uri, KaTeX, seroval, shell-quote, and undici to fix published security advisories. The title is specific enough for a teammate to see the primary change.
-
Full details: Description check
-
Explanation
The description follows the template. It has Problem, Change, Scope and approval, and Verification sections. The Problem section states the advisory issue. The Change section lists each dependency version bump. The Scope section states the PR only applies published security fixes, but it does not link a triaged issue or maintainer approval. The template asks for that link or a justification for skipping it. The Verification section lists focused tests, OSV results, and browser checks, and it states what was not tested. The description also does not state the conventional commit title, but the PR title already uses one. The missing issue or approval link is the main gap.
Resolution
Add a link to the triaged issue or the discussion with explicit maintainer approval of this dependency update. If no prior issue exists, explain why this security dependency update qualifies as a small, focused fix without prior approval. Keep the existing Problem, Change, and Verification sections as they are.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Regenerate the lockfile from the merged manifests to keep upstream mobile and preview dependencies alongside the security fixes.
Problem
The lockfile resolves versions affected by 14 dependency advisories across six packages. Electron 44.9.3 already fixes the other four listed advisories.
Change
Update direct and transitive copies, including mobile KaTeX. Keep undici on its existing major lines.
Scope and approval
This PR only updates dependencies with published security fixes. It adds no features or intentional workflow changes.
Verification
Verified on Linux with Node 26.12.1:
Desktop and native mobile builds were not tested.
gpt-6.1-solin Codex