Skip to content

pdpb: add store scheduling state to GetStore response - #1503

Open
LykxSassinator wants to merge 1 commit into
pingcap:masterfrom
LykxSassinator:client-go-2012-store-routing-state
Open

LykxSassinator wants to merge 1 commit into
pingcap:masterfrom
LykxSassinator:client-go-2012-store-routing-state

Conversation

@LykxSassinator

Copy link
Copy Markdown
Contributor

Summary

Issue: ref tikv/client-go#2012

  • Add StoreSchedulingState to GetStoreResponse for PD-owned, per-store scheduling decisions used by clients during replica selection.
  • Expose evicted_as_slow_store, aligned with PD's recovery-time-based slow-store eviction decision and distinct from local health observations or store lifecycle metadata.
  • Keep the dynamic state scoped to GetStoreResponse, avoiding pollution of the shared metapb.Store metadata path.
  • Document absent state as unknown rather than an implicit false, and reserve the message for independent future constraints such as slow-trend or stopping-store eviction.
  • Regenerate Go protobuf bindings and update proto.lock.

Tests

  • Manual build check

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot

ti-chi-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rleungx for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant