Skip to content

i18n(ja): restore English CLI flag names and argument types in command references - #23394

Open
yahonda wants to merge 3 commits into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-restore-cli-flag-names
Open

i18n(ja): restore English CLI flag names and argument types in command references#23394
yahonda wants to merge 3 commits into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-restore-cli-flag-names

Conversation

@yahonda

@yahonda yahonda commented Jul 31, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

CLI flag names and their argument-type hints are literal parts of the tool's --help output and must stay in English. The machine translation had katakana-ized them in the TiUP / TiDB Cloud CLI (ticloud) command-reference tables. This PR restores them to match the English source.

Two classes of defect fixed (76 rows across 18 files):

  1. Flag names katakana-ized (name was corrupted): --gcs.サービスアカウントキー文字列--gcs.service-account-key string, --s3.アクセスキーID文字列--s3.access-key-id string, --csv.スキップヘッダー--csv.skip-header, --csv.バックスラッシュエスケープ--csv.backslash-escape, --csv.null値文字列--csv.null-value string, --マスターアドレス--master-addr, and --文字列--where string (the --where name had been dropped entirely).

  2. Argument-type hint translated (string文字列): normalized back to English so the type column is consistent with the int / int32 / strings hints that were already kept in English (e.g. --s3.secret-access-key 文字列--s3.secret-access-key string, --role 文字列--role strings).

All flag cells were verified 1:1 against the English release-8.5 source (including plural strings for --filter / --role / --add-role / --delete-role).

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from: N/A (Japanese-only fix; no English source change)
  • Other reference link(s): part of the i18n-ja-release-8.5 machine-translation cleanup series

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

…d references

The machine translation katakana-ized CLI flag names and their argument-type
hints in the TiUP/TiDB Cloud CLI (ticloud) reference tables, e.g.
--gcs.サービスアカウントキー文字列, --s3.アクセスキーID文字列, --csv.スキップヘッダー,
--マスターアドレス. Flag names and their type hints are literal CLI (`--help`)
output and must stay English, matching the English source and the int/int32/
strings hints that were already kept in English. Restore them (name → English,
文字列 → string / strings) across 18 command-reference files (76 rows).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@ti-chi-bot

ti-chi-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lilin90 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a99e405a-3807-4bae-87a0-5f235960d62a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 31, 2026
yahonda and others added 2 commits July 31, 2026 14:33
Follow-up: the first pass only handled flag cells that begin with `--`, so
short-form flags written as `-c, --cluster-id 文字列` / `-n, --display-name 文字列`
/ `-P, --profile 文字列` / `-u, --user 文字列` were left with the Japanese type,
leaving the tables mixed. Normalize their type hint 文字列 → string too, so every
flag cell is English and matches the source. 37 rows.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Complete the flag tables: a few flags were missing the ` string` type hint that
the English source has (--private-key/--public-key/--cloud-storage/--rule/
--new-display-name/--compression/--password). Add ` string` so every flag cell
matches the English source.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant