check-before-deployment: fix TuneD custom profile path - #21925
doc-claw-bot wants to merge 4 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthrough更新 TuneD 自定义策略的目录路径,并补充 TuneD v2.23.0 前后的版本要求。 ChangesTuneD 策略路径
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: 🔵 Low · up to The documentation correctly distinguishes the default TuneD paths by version, but users with customized profile directories may create profiles in a location TuneD does not scan. Clarify that the paths apply to default configuration before merging. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 42d11119-22f9-44e3-abc1-09679ad14552
📒 Files selected for processing (1)
check-before-deployment.md
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 461df81d-91f8-47cb-b8b6-ceaba396076d
📒 Files selected for processing (1)
check-before-deployment.md
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
[P2] 建议调整按 TuneD 版本选择策略目录的说明:发行版可能保留旧目录。 针对当前提交 已检查 Rocky Linux 9 官方发布的 USER_PROFILES_DIR = "/etc/tuned"
SYSTEM_PROFILES_DIR = "/usr/lib/tuned"
CFG_DEF_PROFILE_DIRS = [SYSTEM_PROFILES_DIR, USER_PROFILES_DIR]随包的
验证范围是实际 RPM 内容和策略查找逻辑,未启动完整 TuneD 服务。这个反例说明,用户按当前“≥2.23”示例创建策略后,可能无法应用该策略。RHEL 9 官方文档也明确使用 建议做以下修改:
|
What is changed, added or deleted? (Required)
check-before-deployment.md./etc/tuned/<profile_name>/tuned.conf/etc/tuned/profiles/<profile_name>/tuned.confWhich TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
/etc/tuned/<profile_name>/tuned.conf,v2.23.0 及以上使用/etc/tuned/profiles/<profile_name>/tuned.conf。