Support deptrac 4 - #2
Merged
Merged
Conversation
deptrac stopped shipping a PHAR release asset with 3.0, so the previous GitHub tool source (constraint ^0.19, repository qossmic/deptrac) can no longer provide a usable binary. - phpcq-plugin.json: replace the tool/PHAR source with a composer requirement (deptrac/deptrac ^4.0); raise PHP requirement to ^8.3 and declare ext-json - src/deptrac.php: run the composer-installed vendor/bin/deptrac through buildPhpProcess() instead of buildRunPhar(); mention deptrac.php in the config-file option description - tests: replace the smoke tests with assertions covering the described configuration options and the built process invocation (binary path, base arguments, optional argument handling) - README: note the Composer-based tool acquisition
discordier
approved these changes
Sep 7, 2026
discordier
left a comment
discordier
left a comment
Member
There was a problem hiding this comment.
LGTM but should become a new minor release - not a bugfix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deptrac stopped attaching a
deptrac.pharto its GitHub releases with 3.0, so the current tool source (constraints: ^0.19,repository: qossmic/deptrac) can no longer resolve a usable binary. deptrac is now Composer-only.Changes
phpcq-plugin.json: replace thetool/ GitHub-PHAR source with acomposerrequirement (deptrac/deptrac: ^4.0); raise the PHP requirement to^8.3and declareext-json.src/deptrac.php: run the Composer-installedgetInstalledDir()/vendor/bin/deptracviabuildPhpProcess()instead ofbuildRunPhar(). CLI arguments and the JSON output transformer are unchanged –deptrac 4.7.1 still accepts
analyse --no-progress --formatter=json --output=…(plus the global
--config-file/--no-cache/--cache-file) and the JSONstructure (
files → messages[] → {message, line, type}) is identical.the described configuration options and the built process invocation (binary
path, base arguments, and optional-argument handling). 7 tests / 18 assertions.
README.md: note the Composer-based tool acquisition.Notes
composerrequirement pattern already used byphpcq/plugin-rectorandphpcq/plugin-doctrine-coding-standard.^8.3in line with itsown
composer.json.