Applied fixers to improve test robustness (ext/intl, ext/phar) - #22985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! As requested in #22799 (comment) I carry over commits into separate PRs for extensions. This was cherry picket from #22799 (where the deterministic proof is).
Regarding style-only concerns, I manually reviewed the diff here:
echo&var_dump()to the normalisedecho(Daniel explicitly mentioned no objections to it).php-src(see Tests: Test exception type in error tests #22799 (comment)); as proposed by Daniel.The more individual extension PRs are merged, the smaller the diff in the main PR, the easier to review. Merging this one will decrease diff size in the main PR by ~1,000 lines (~6%), and will decrease its affected files by 250 files (~9%).