Repository navigation
fix: preserve absent simulation report identities - #544
Merged
Merged
Conversation
Signed-off-by: jbernavaprah <webjure@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The simulator's existing internal failure reports serialize an absent scope, supervisor identity or run identity as null.
The shared finite-report type currently requires strings and rejects those reports, hiding their real failure and successful cleanup evidence from typed consumers.
Represent these three observed identities as
Option<String>, preserving explicit nulls and present string values.Runtime admission still requires the identities, and the report's success and cleanup predicate remain unchanged.
No execution or lifecycle policy moves into the SDK.
Validation covers the retained actual null-identity failure packets and actual present-identity success and failure packets, including rich terminal evidence and duplicated stdout.
Focused owner tests pass 7/7, base library tests 76/76 and all-feature library tests 268/268, with no ignored tests.
Strict all-feature all-target Clippy, warning-denying docs, formatting and diff checks pass.
Independent review inspected the complete one-file diff and re-executed seven focused tests and typed exact roundtrips of all five actual packets against the release-based SDK source.
Public archive and clean consumer verification follow normal owner publication before dependent applications are delivered.