Repository navigation
feat: share finite simulation report records - #542
Merged
Merged
Conversation
Signed-off-by: jbernavaprah <webjure@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The simulator producer and Cargo consumer currently define the same finite-run report separately.
Define
SimulationCleanupandSimulationRunReport<Terminal = SimulatorTerminalEvidence>in the framework artifact owner so both applications consume one passive contract.The V0 schema, field names and types, explicit null serialization, duplicated terminal stdout and existing success predicate stay unchanged.
The terminal parameter preserves application-owned rich or borrowed terminal evidence without moving execution or cleanup policy into the SDK.
Update the two artifact modules' ownership documentation.
Validation: base library tests 75/75, all-feature library tests 267/267, independent focused simulation-record tests 6/6, strict all-feature/all-target Clippy, warning-denying docs, formatting and diff checks passed.
New assertions cover whole-report/null roundtrips, rich and borrowed terminal/scenario serialization, narrow typed consumption and failed exit/readiness/provider/cleanup outcomes.
Application integration and published consumer verification follow the framework release.