Skip to content

test: isolate diary ring coverage from runtime observations - #539

Merged
jBernavaPrah merged 1 commit into
mainfrom
fix/diary-test-observation-isolation
Oct 7, 2026
Merged

jBernavaPrah merged 1 commit into
mainfrom
fix/diary-test-observation-isolation

Conversation

@jBernavaPrah

Copy link
Copy Markdown
Contributor

The independent ring-bound test cleared the observation buffer owned by generated-runtime diary tests without taking their fixture lock.
A concurrent clear after reset's accepted invocation erased its recorded empty-ring observation and made the unchanged reset assertion report the fallback count of one.

Remove the unused shared-buffer clear from the local ring exercise.
Run that same exercise between the real generated owner's reset invocation and its observation assertion to protect this interference boundary deterministically.
Production diary behavior, bounds, reset semantics and suite scheduling remain unchanged.

Validation:

  • Preserved original CI failure and reproduced the same expected-0/observed-1 failure by deliberately interleaving the actual ring test at the reset assertion boundary.
  • Parallel SDK unit surface: 115 passed, zero ignored.
  • Isolated observer target: 4 passed, zero ignored.
  • Strict Clippy for both targets, formatting and whitespace checks passed.

Signed-off-by: jbernavaprah <webjure@gmail.com>
@jBernavaPrah
jBernavaPrah merged commit f947133 into main Oct 7, 2026
3 checks passed
@jBernavaPrah
jBernavaPrah deleted the fix/diary-test-observation-isolation branch October 7, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant