Skip to content

fix: issues #407–#411 (7.2.0) - #412

Merged
PrzemekGalarowicz merged 9 commits into
mainfrom
fix/issues-407-411
Nov 2, 2026
Merged

PrzemekGalarowicz merged 9 commits into
mainfrom
fix/issues-407-411

Conversation

@PrzemekGalarowicz

Copy link
Copy Markdown
Member

Fixes the five open bugs from 2026-11-02 in one release, 7.2.0.

Issue What changed How it was built
#407 The capability counters and validate.mjs now share one git-aware file list (pharn/floor/capability-files-core.mjs). Git-ignored copies of a capability are no longer counted twice. The project's own pharn/ is still listed even when ignored. By hand (small)
#408 Reconcile leaves PHARN's own run state, pharn/.run/, out of the reconciled set. A project that doesn't git-ignore that folder no longer fails verify on its own stage logs. /pharn-dev-ship
#409 /pharn-test runs the project's style gates before and after it writes the AC tests (check-ac-style.mjs). It refuses with ac-tests-unformatted before pinning tests that broke a gate that was passing. /pharn-dev-ship
#410 stage-agent.mjs finish --budget-ms at the cap exits 6 and leaves the stage open instead of closing it as a refusal. /pharn-loop stops at the new S9b stage-outlived-wait. /pharn-dev-ship
#411 The cost ledger no longer warns about missing iterations on a stop before the first build. A routed /pharn-loop test-stage agent reports refused with no row. By hand (small)

Closes #407, closes #408, closes #409, closes #410, closes #411.

Evidence

Not in this PR

🤖 Generated with Claude Code

PrzemekGalarowicz and others added 8 commits November 2, 2026 16:01
…nd test-stage row (#411)

- capability-files-core.mjs: one markdown list for validate and the three counters —
  git's tracked + untracked-not-ignored files plus the target's own pharn/, with the old
  walk as the fallback — so a git-ignored copy of pharn/ is no longer counted.
- check-cost-ledger.mjs: no iteration WARN on a stop before the first build.
- stage-agent-core.mjs: the loop's test-stage agent reports refused with no row.
- Opens SKILLS_VERSION 7.2.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ee fixtures

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ved-wait (#410)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…in sentence (#409 review)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1e531155-623a-4209-a3d4-473b9ef02dd4
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

pharn

🛡️ pharn-ci · ✅ Pass

Tip

Pass · Diff coverage of this change is 100% against a threshold of 100%; 38 agent setup files found.

Verdict Diff coverage Test integrity Agent setup
✅ Pass 100% (threshold 100%) none (block) 38 files

🧪 Diff coverage

100% of changed lines covered (613/613, threshold 100%)

Changed files (13)
File Coverage Covered Uncovered lines
pharn/floor/ac-style-core.mjs 100% 176/176
pharn/floor/capability-files-core.mjs 100% 113/113
pharn/floor/check-ac-style.mjs 100% 183/183
pharn/floor/check-bash-reconcile.mjs 100% 14/14
pharn/floor/check-cost-ledger.mjs 100% 6/6
pharn/floor/count-grillers.mjs 100% 7/7
pharn/floor/count-lenses.mjs 100% 7/7
pharn/floor/count-verifiers.mjs 100% 7/7
pharn/floor/reconcile-baseline.mjs 100% 25/25
pharn/floor/stage-agent-core.mjs 100% 39/39
pharn/floor/stage-agent.mjs 100% 19/19
pharn/floor/validate.mjs 100% 9/9
pharn/floor/worktree-fingerprint.mjs 100% 8/8

🔍 Test integrity

No test-integrity findings (mode: block).

💬 Messages (1)

  • ℹ️ COVERAGE_PATHS_PARTIALLY_UNMATCHED 122 file paths in the coverage report are not tracked files in the repository; their coverage is not used.
    • Hint: Nothing to do if those files are generated or outside the repo; if changed files are missing from the table, check the coverage root.

🤖 Agent setup (38 files)

Agent setup: 38 files · claude-code

Agent setup files (38)
Path Kind
.claude/agents/pharn-review-lens.md claude-agent
.claude/commands/pharn-build.md claude-command
.claude/commands/pharn-dev-build.md claude-command
.claude/commands/pharn-dev-eval.md claude-command
.claude/commands/pharn-dev-grill.md claude-command
.claude/commands/pharn-dev-memory-promote.md claude-command
.claude/commands/pharn-dev-plan.md claude-command
.claude/commands/pharn-dev-regress.md claude-command
.claude/commands/pharn-dev-review.md claude-command
.claude/commands/pharn-dev-ship.md claude-command
.claude/commands/pharn-dev-verify.md claude-command
.claude/commands/pharn-grill.md claude-command
.claude/commands/pharn-loop-close.md claude-command
.claude/commands/pharn-loop-quick.md claude-command
.claude/commands/pharn-loop.md claude-command
.claude/commands/pharn-memory-promote.md claude-command
.claude/commands/pharn-plan.md claude-command
.claude/commands/pharn-regress.md claude-command
.claude/commands/pharn-review.md claude-command
.claude/commands/pharn-ship-close.md claude-command
.claude/commands/pharn-ship-quick.md claude-command
.claude/commands/pharn-ship-stages.md claude-command
.claude/commands/pharn-ship.md claude-command
.claude/commands/pharn-spec.md claude-command
.claude/commands/pharn-test.md claude-command
.claude/commands/pharn-verify.md claude-command
.claude/hooks/enforce-writes-scope.cjs claude-hook
.claude/hooks/enforce-writes-scope.test.cjs claude-hook
.claude/hooks/hook-wiring.test.cjs claude-hook
.claude/hooks/protect-trusted-paths.cjs claude-hook
.claude/hooks/protect-trusted-paths.test.cjs claude-hook
.claude/hooks/require-loop-record.cjs claude-hook
.claude/hooks/require-loop-record.test.cjs claude-hook
.claude/hooks/set-writes-scope.cjs claude-hook
.claude/hooks/set-writes-scope.test.cjs claude-hook
.claude/hooks/writes-scope-release.test.cjs claude-hook
.claude/settings.json claude-settings
CLAUDE.md claude-md

pharn-ci 0.2.0 · report schema v2 · coverage format lcov

… its coverage (PR #412)

The tests spawned a copy under a temp dir, so the lcov report credited the copy and
pharn-ci read the committed file at 32.79%. Also covers its two invalid-JSON refusals.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@PrzemekGalarowicz
PrzemekGalarowicz merged commit ea11383 into main Nov 2, 2026
8 checks passed
@PrzemekGalarowicz
PrzemekGalarowicz deleted the fix/issues-407-411 branch November 2, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment