Skip to content

feat(pharn): strengthen workflow gates and evidence - #105

Merged
PrzemekGalarowicz merged 2 commits into
mainfrom
update-pharn
Oct 20, 2026
Merged

PrzemekGalarowicz merged 2 commits into
mainfrom
update-pharn

Conversation

@PrzemekGalarowicz

Copy link
Copy Markdown
Member

What this changes

Strengthens PHARN workflow reliability by extracting ship-stage guidance, adding shared canonical-root and command-section helpers, and tightening acceptance-test, provenance, regression, and loop-decision gates. Updates stage and regression reporting, workflow contracts, limits/threat-model documentation, and write-scope hooks to keep implementation boundaries explicit.

Type of change

  • feat — new capability
  • fix — bug fix
  • docs — docs-only change
  • chore / refactor / test / ci — no behavior change

Module(s) touched

PHARN commands, hooks, floor tooling, and contracts (repo tooling/docs).

Checklist

  • Tests added or updated (bug fixes include a regression test).
  • No third-party dependency or cross-module import added to src/agent; no runtime
    dependencies added to the root package.json.
  • TypeScript strict; no any without a comment explaining why.
  • Streams use stream/promises pipeline(), never .pipe(); no stream, worker or plugin
    execution without explicit error handling.
  • async_hooks is imported only in src/agent/context.ts; worker files live in
    */src/workers/.
  • Counter aggregation uses integer math.
  • Docs updated (README.md, ARCHITECTURE.md, FEATURES.md) if behavior or scope changed.

Overhead (required for changes in the agent's hot path)

n/a — no agent hot-path changes.

Security-sensitive changes

Updated PHARN write-scope/trusted-path hooks and security scan gates. npm test passed; no runtime dashboard, authentication, plugin sandbox, or analyzer parsing code changed.

Notes for the reviewer

Validation: npm test — passed (167 test files, 343 tests). The patch updates test infrastructure and acceptance-test locking, but adds no standalone test files. Review the write-scope enforcement and canonical-root handling alongside the strengthened workflow gates.

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9f1313f4-c81d-4aa3-865c-890ca1b7b27d
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

pharn

🛡️ pharn-ci · ✅ Pass

Tip

Pass · This change adds no coverable lines; 31 agent setup files found.

Verdict Diff coverage Agent setup
✅ Pass no coverable lines 31 files

🧪 Diff coverage

No coverable lines changed.

💬 Messages (1)

  • ℹ️ NO_COVERABLE_CHANGES No added lines are tracked by the coverage report; nothing to measure.
    • Hint: Nothing to do if the change has no code; otherwise check that the coverage report includes the changed files.

🤖 Agent setup (31 files)

Agent setup: 31 files · claude-code

Agent setup files (31)
Path Kind
.claude/commands/pharn-build.md claude-command
.claude/commands/pharn-grill.md claude-command
.claude/commands/pharn-loop-close.md claude-command
.claude/commands/pharn-loop-quick.md claude-command
.claude/commands/pharn-loop.md claude-command
.claude/commands/pharn-memory-promote.md claude-command
.claude/commands/pharn-plan.md claude-command
.claude/commands/pharn-regress.md claude-command
.claude/commands/pharn-review.md claude-command
.claude/commands/pharn-ship-close.md claude-command
.claude/commands/pharn-ship-quick.md claude-command
.claude/commands/pharn-ship-stages.md claude-command
.claude/commands/pharn-ship.md claude-command
.claude/commands/pharn-spec.md claude-command
.claude/commands/pharn-test.md claude-command
.claude/commands/pharn-verify.md claude-command
.claude/hooks/enforce-writes-scope.cjs claude-hook
.claude/hooks/protect-trusted-paths.cjs claude-hook
.claude/hooks/require-loop-record.cjs claude-hook
.claude/hooks/set-writes-scope.cjs claude-hook
.claude/settings.json claude-settings
.claude/skills/phargus-diagnose claude-skill
.claude/skills/phargus-memory claude-skill
.claude/skills/phargus-rules claude-skill
.claude/skills/phargus-setup claude-skill
.claude/skills/phargus-verify claude-skill
.claude/skills/pharn-ci-cover claude-skill
.claude/skills/pharn-ci-explain claude-skill
.claude/skills/pharn-ci-install claude-skill
.claude/skills/pharn-cli claude-skill
CLAUDE.md claude-md

pharn-ci 0.1.0 · report schema v1 · coverage format lcov

@PrzemekGalarowicz
PrzemekGalarowicz merged commit 9840534 into main Oct 20, 2026
15 checks passed
@PrzemekGalarowicz
PrzemekGalarowicz deleted the update-pharn branch October 20, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant