Fix existingSecret path in Helm deployment template

[dpage]

Summary

deployment.yaml's annotation conditions referenced the non-existent top-level .Values.existingSecret instead of .Values.auth.existingSecret, so the secret checksum annotation and the empty-secret gating never worked as intended when an existing secret wasn't supplied. secret.yaml already uses the correct .Values.auth.existingSecret path.

Fixes #10214.

Test plan

• Manually traced every existingSecret reference across the chart's templates and values.yaml to confirm .Values.auth.existingSecret is the only path that actually exists
• helm lint/helm template (not available in this environment; the change is a straightforward path correction matching the existing pattern used elsewhere in the same file)

Summary by CodeRabbit

• Bug Fixes
  • Fixed Helm deployment configuration so secret checksum annotations correctly use the configured authentication secret.
  • Prevented deployment annotations from referencing an outdated secret configuration value.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 986ff037-b7a2-4b16-a87e-37ff19570d7b

📥 Commits

Reviewing files that changed from the base of the PR and between 0ebefaf and bd252ca.

📒 Files selected for processing (1)

• pkg/helm/templates/deployment.yaml

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.

---

Walkthrough

The Helm deployment template now checks .Values.auth.existingSecret for pod annotation and secret checksum conditions.

Changes

Helm secret configuration

Layer / File(s)	Summary
Update deployment secret conditions pkg/helm/templates/deployment.yaml	The deployment template replaces .Values.existingSecret with .Values.auth.existingSecret for both annotation conditions.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: ⚪ Minimal · up to bd252

This change corrects the existing-secret value path used by deployment annotations and secret gating. The behavior is localized, and no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: maddin-m

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the fix to the existingSecret path in the Helm deployment template.
Linked Issues check	✅ Passed	The change updates both deployment conditions to use .Values.auth.existingSecret, matching issue #10214 and secret.yaml.
Out of Scope Changes check	✅ Passed	The pull request changes only the existingSecret references required by issue #10214.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}