Repository navigation
docs: move the README notes to docs/configuration.md, and fix three bugs - #85
Merged
Merged
Conversation
The README now has only the features, the requirements, the installation, the setup, and the default config. The notes on trigger actions, trailers, filtering, sorting, and hosted instances move to docs/configuration.md, and the README links to each section. docs/configuration.md also documents behavior that no doc described: the format functions and item fields, sort_by, filetypes, remotes and ssh_aliases, gh repo set-default, Octo buffers, the differences between the CLIs and curl, the debug log, and the cache for each buffer. These docs were wrong: - GitHub mentions are not curl only. They use gh api since 73f6b7f. - The GitHub issue filter has no subscribed or repos value since 40725f6. - The default config did not show ssh_aliases, added in c1f76bf. - The source functions take no config table since b414e48. - The hosted instances example had no closing parenthesis.
The Neovim nightly job tests the newest overlay commit that is in the cache, not the locked one. CONTRIBUTING.md now gives the commands that run the same test locally with scripts/nightly-cache.sh latest.
The comment listed author_email, but the commit field is author_mail, so sort_by = "author_email" gives no sortText.
The issues and pull requests action put the cached issue list in its result, and then added the pull requests to that list. As a result, the issue cache also got the pull requests, and github_issues then returned them. A cache hit returned only the issue cache, which gave the correct result only because of this mixed cache. The pull request job was also made before the issues were known. On a pull request cache hit, the callback ran at once without the issues. The action now builds a new list from the two results, and requests the pull requests only after the issues are known.
The REST issues endpoint also returns pull requests, with a pull_request field. gh issue list does not. With curl, # showed each pull request two times: as an issue and as a pull request. The issues request now removes the items that have a pull_request field. Because the pull requests use part of the page, curl can give fewer issues than limit. docs/configuration.md tells this.
The author_name and author_mail fields came from %cn and %ce, which are the committer. After a rebase or a cherry-pick by another person, the commit documentation showed that person as the author. The fields now come from %aN and %aE, so they respect the mailmap, as the trailer identities do. The documentation now says "Authored by <name> (<email>), committed on <date>" in place of "Commited by". The date is still the commit date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the notes from the README to
docs/configuration.md, corrects the docs that were wrong, and documents behavior that no doc described. It also fixes three bugs that were found while reading the code for the docs.Changes
docs/configuration.md.formatfunctions, the item fields of each capability,sort_by, and the default sort orders."*"and compound filetypes.remotes,enableRemoteUrlRewrites,ssh_aliases,gh repo set-default, and Octo buffers.vim.g.cmp_git_debug, and the cache for each buffer.scripts/nightly-cache.sh latest, as theNeovim nightlyjob does.Doc corrections
curlonly". They usegh apisince73f6b7f(2023).github.issues.filtercomment listedsubscribedandrepos.40725f6removed these values.ssh_aliases, whichc1f76bfadded.b414e48.).sort.luacomment named the fieldauthor_email. The field isauthor_mail.Bug fixes
Each fix is a separate commit with regression tests. The new tests fail on the old code.
a503fea fix: keep the GitHub issue and pull request caches separate:github_issuesreturned them.b7a3f50 fix: remove pull requests from the GitHub issues that curl gets: the REST issues endpoint also returns pull requests, so#showed each pull request two times. The issues request now removes the items that have apull_requestfield. The pull requests use part of the page, so curl can give fewer issues thanlimit.docs/configuration.mdtells this.fc8f7df fix: show the commit author, not the committer:author_nameandauthor_mailcame from%cnand%ce. They now come from%aNand%aE, as the trailer identities do. The documentation window now says "Authored by NAME (EMAIL), committed on DATE" in place of "Commited by". The date is still the commit date.Validation (local)
make ciexits 0 in thedefaultshell (Neovim 0.12.6) and with Neovim v0.13.0-nightly+1cfebe9 fromPATH.make testpasses in thenvim-0_12_0shell.make testpasses on each fix commit.