Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ServerManagerstarts the Playwright server withProcess::fromShellCommandline('./node_modules/.bin/playwright run-server …'). Symfony Process runs a string command through/bin/sh -c. When/bin/shis dash (Debian, Ubuntu, the official PHP Docker images), the shell does not exec the command, so the process tree is:PlaywrightNpmServer::stop()terminates the process it knows about, which is the shell.nodekeeps running, reparented to PID 1. Every run that includes browser tests leaves one Playwright server behind, about 100 MB each. In a long-lived dev container they pile up until the container runs out of memory (we had 72).Fix
Prefix the command with
execon non-Windows systems. The shell then replaces itself withnode, andstop()reaches the server. Windows is unchanged, sinceexecis not acmdbuiltin.Reproduction
Start and stop the server the way the plugin does:
Running a browser test file in a
php:8.5based container leaves one orphan per run before this change and none after it.🤖 Generated with Claude Code