Skip to content

fix: await the matching navigation command response (4.x backport) - #303

Open
tiagoabsantos wants to merge 1 commit into
pestphp:4.xfrom
tiagoabsantos:fix/await-navigation-response
Open

tiagoabsantos wants to merge 1 commit into
pestphp:4.xfrom
tiagoabsantos:fix/await-navigation-response

Conversation

@tiagoabsantos

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • Unit: goto and reload keep reading after load events from another document and a child frame, then accept the matching command response
  • Unit: a navigation error that arrives after a stray load event is reported
  • Browser: visit() then navigate() and the first script() reads the requested document title
  • CI on PHP 8.3, 8.4, and 8.5

Refs pestphp/pest#1943

A load event from another document was treated as the
end of goto and reload. Wait for the command response
instead. Playwright already applies waitUntil.

Refs pestphp/pest#1943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant