Repository navigation
fix: await the matching navigation command response (4.x backport) - #303
Open
tiagoabsantos wants to merge 1 commit into
Open
tiagoabsantos wants to merge 1 commit into
tiagoabsantos wants to merge 1 commit into
Conversation
A load event from another document was treated as the end of goto and reload. Wait for the command response instead. Playwright already applies waitUntil. Refs pestphp/pest#1943
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Client::execute()treated anyloadevent matchingwaitUntilas the end ofgotoandreload, including a load from the previous document or a child frame.waitUntilbefore that response arrives.4.x. Pest 4.7.8 with plugin v4.3.1 still has the early return reported in [Bug]: pest-plugin-browser: Page::goto() returns on the first "load" event from any document, not when its own navigation has loaded pest#1943.Test plan
gotoandreloadkeep reading after load events from another document and a child frame, then accept the matching command responsevisit()thennavigate()and the firstscript()reads the requested document titleRefs pestphp/pest#1943