Repository navigation
fix: capture CSP violations and optional console levels - #299
Open
tiagoabsantos wants to merge 1 commit into
Open
tiagoabsantos wants to merge 1 commit into
tiagoabsantos wants to merge 1 commit into
Conversation
assertNoJavaScriptErrors() missed securitypolicyviolation, so a report-only Content-Security-Policy could still pass. Record those violations. assertNoConsoleLogs() keeps checking console.log only, and now accepts levels so error, warn, info, and debug can be included without turning existing suites red.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assertNoJavaScriptErrors()now recordssecuritypolicyviolation, includingContent-Security-Policy-Report-Only. Unhandled promise rejections were already captured in fix: capture unhandled promise rejections in assertNoJavaScriptErrors #255.assertNoConsoleLogs()still checks onlyconsole.logby default, so existing suites stay green. Passerror,warn,info,debug, orwarningto include those console methods. The init script records all of them.Test plan
img-srcviolations failassertNoJavaScriptErrors()assertNoConsoleLogs()still ignoresconsole.error,warn,info, anddebugassertNoConsoleLogs('error')andassertNoConsoleLogs(['error', 'warn'])fail with the matching messagesInvalidArgumentException