Repository navigation
fix: count a failed browser check as an assertion - #298
Open
vasikmansuri wants to merge 1 commit into
Open
vasikmansuri wants to merge 1 commit into
vasikmansuri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes case 1 of pestphp/pest#2009.
A test whose first browser check fails, e.g.
visit('/ok')->assertSee('Goodbye'), is reported as failed with 0 assertions and also as risky ("This test did not perform any assertions").assertSee(),assertDontSee(), failed actions andGuessLocatorthrowExpectationFailedExceptionwithout counting an assertion, while PHPUnit's own assertions count before they throw.Every failing page call goes through the
catch (ExpectationFailedException)inAwaitableWebpage::__call(), so this counts the failed check there, once, instead of before each throw.Test:
counts a failed check as an assertioninAssertSeeTestfails without the change (0 vs 1) and passes with it. The fulltests/Browsersuite passes locally (277 tests).Cases 2 and 3 of the issue (a server exception from an earlier page reaching later pages, and the plugin's frames in failure traces) are left for separate PRs.