Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
We use this plugin with Boost in a Laravel app that already has
pestphp/pest-plugin-browserinstalled. The generated guidelines still told the agent to ask before installing it and listed the composer/npm/npx commands, which is about 15 lines every agent reads for nothing.This wraps the install part in
@if (! \Composer\InstalledVersions::isInstalled('pestphp/pest-plugin-browser')). Thevisit()intro and the example commands still render either way. I shortened the heading to "Browser checks require the browser plugin" since it now shows in both cases. The "ask the user for permission first" line is still there when the plugin is missing.I went with
InstalledVersionsover$assist->hasPackage()becausehasPackage()only takes a package name string from Boost 2.5.0. On 2.4.x, which you can still get with Pest 5.0.3 to 5.1.2, it throws andboost:installfails. I checkedboost:installandboost:updateon Boost 2.4.13 and 2.10.3, with and without the browser plugin.