Auto legend - #3225
Merged
Merged
Conversation
Signed-off-by: Andrew Stein <steinlink@gmail.com>
Signed-off-by: Andrew Stein <steinlink@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
legend_mode: "auto", the default (now) for the just addedlegend_modeplugin config setting, which chooses via heuristic which legend mode to choose.legend_mode: "auto"(new default):"floating"when every entry fits without scrolling (≤ 7 rows; continuous gradient legends always qualify),"sidebar"otherwise, so a long list gets dedicated scrollable space instead of occluding the plot. Treemap and Hetmap overrides the default to"sidebar"(as they are full-panel always).legend_size_mode: "auto" | "fixed"(new, default"auto", floating mode only) sizes the panel to its contentDrive-by fixes: this PR also fixes support for
Int8,UInt8,Int16,UInt16to theView::with_typed_arraysmethod (only used by charts), which was uncovered by legend testing.