Repository navigation
[FEATURE] Add optional links to the Exemplar type (perses#3445) - #118
Open
julianocosta89 wants to merge 2 commits into
Open
julianocosta89 wants to merge 2 commits into
julianocosta89 wants to merge 2 commits into
Conversation
Contributor
|
@julianocosta89 can you please sign your commits? |
Member
|
@julianocosta89 do you mind to signoff your commit, we will then be able to move forward |
julianocosta89
force-pushed
the
exemplars/3445-exemplar-links
branch
from
October 27, 2026 10:08
a29b35c to
357a1fb
Compare
Contributor
Author
|
@jgbernalp and @Nexucis sorry, I was off last week and couldn't do it. |
Contributor
Author
|
I believe the failing CI is not related to this PR |
Query plugins (e.g. PrometheusTimeSeriesQuery) will compute these links from the datasource exemplars configuration (URL template + trace ID label) so that exemplar tooltips can offer a jump to a tracing UI without the panels or the shared tooltip knowing anything about the datasource. Signed-off-by: Juliano Costa <julianocosta89@outlook.com>
julianocosta89
force-pushed
the
exemplars/3445-exemplar-links
branch
from
October 27, 2026 11:13
357a1fb to
ed01fba
Compare
Contributor
|
We fixed the CI in #125, mind rebasing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First step of the "embed links" part of the exemplars roadmap (perses/perses#3445, step 2): extends the query-result contract with an optional
linksfield onExemplar.The design keeps the division of responsibilities clean:
ExemplarLink[]as clickable buttons. Any panel that displays exemplars gets link support for free, and any query plugin can produce links without the UI knowing anything about the datasource.The field is optional, so the change is fully backwards compatible: older dashboards/datasources load unchanged, and plugins that don't produce links keep the payload identical.
Testing
TimeSeriesDataand its exemplar types exist only in the TS part of the spec (query-result contract, not a persisted resource) — verified there are no exemplar references incue/,go/orjava/.