Repository navigation
UI Customization, fix selection size tests and improve style consumer types - #403
Merged
Merged
Conversation
jgbernalp
commented
Oct 27, 2026
jgbernalp
commented
Contributor
- Add selection control sizes to type definitions and tests
- Wrap style prop definition so consumers don't need to cast when defining custom style props in components
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
jgbernalp
changed the title
…dding a new component, more info about inline 'style' and custom properties Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
…st of components Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
zhuje
added a commit
that referenced
this pull request
Oct 28, 2026
Follows #403: type style as PersesCSSProperties on CardProps, CardHeaderProps and CardContentProps so consumers can pass --perses-* and application variables without casting. The registry-derived check in types.test.tsx flagged Card after rebasing onto ui-customization; this resolves it. Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
zhuje
added a commit
that referenced
this pull request
Oct 28, 2026
Type style as PersesCSSProperties on GridProps and GridItemProps so the registry-derived check from #403 passes, and drop the as CSSProperties cast that only existed to smuggle --ps-grid-columns past the old type. Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.