Skip to content

[FEATURE] Add item actions to tracingganttchart - #882

Merged
Gladorme merged 8 commits into
perses:mainfrom
Gladorme:ganttchart/item-actions
Oct 27, 2026
Merged

Gladorme merged 8 commits into
perses:mainfrom
Gladorme:ganttchart/item-actions

Conversation

@Gladorme

@Gladorme Gladorme commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Description

Adding Item Actions to Tracing Gantt Chart plugin. It's adding trace selection chebox and button in detail panel.

Screenshots

image image

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.

@Gladorme
Gladorme marked this pull request as ready for review October 20, 2026 13:39
@Gladorme
Gladorme requested review from a team, AntoineThebaud and Nexucis as code owners October 20, 2026 13:39
@Gladorme
Gladorme requested review from adrianSepiol and removed request for a team October 20, 2026 13:39
@AntoineThebaud
AntoineThebaud requested a balanced review from Copilot October 20, 2026 13:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Same-trace refreshes can leave action payloads stale, and failure feedback and mixed-state accessibility need correction.

5 open issues
What changed in this PR

Adds configurable span selection and item actions to the Tracing Gantt Chart plugin.

Changes:

  • Adds span checkboxes and detail-pane action buttons.
  • Extends configuration, schemas and Go SDK support.
  • Adds tests and documents action payloads and usage.
File Description
tracingganttchart/​src/​TracingGanttChartPanel.tsx Keys chart instances by trace ID.
tracingganttchart/​src/​TracingGanttChartItemSelectionActionsEditor.tsx Adds selection and action settings.
tracingganttchart/​src/​TracingGanttChart/​TracingGanttChart.tsx Connects detail-pane actions.
tracingganttchart/​src/​TracingGanttChart/​trace.ts Adds trace ID extraction.
tracingganttchart/​src/​TracingGanttChart/​trace.test.ts Tests trace ID extraction.
tracingganttchart/​src/​TracingGanttChart/​span-actions.ts Builds payloads and manages selection.
tracingganttchart/​src/​TracingGanttChart/​span-actions.test.tsx Tests payloads and selection lifecycle.
tracingganttchart/​src/​TracingGanttChart/​GanttTable/​SpanName.tsx Adds row selection checkboxes.
tracingganttchart/​src/​TracingGanttChart/​GanttTable/​SpanCheckbox.tsx Introduces compact span checkboxes.
tracingganttchart/​src/​TracingGanttChart/​GanttTable/​GanttTableRow.tsx Passes row selection controls.
tracingganttchart/​src/​TracingGanttChart/​GanttTable/​GanttTableHeader.tsx Adds select-all control.
tracingganttchart/​src/​TracingGanttChart/​GanttTable/​GanttTable.tsx Integrates selection into the table.
tracingganttchart/​src/​TracingGanttChart/​GanttTable/​GanttTable.test.tsx Tests checkbox interactions.
tracingganttchart/​src/​TracingGanttChart/​DetailPane/​SpanActionButtons.tsx Executes actions with confirmation.
tracingganttchart/​src/​TracingGanttChart/​DetailPane/​DetailPane.tsx Displays span action buttons.
tracingganttchart/​src/​TracingGanttChart/​DetailPane/​DetailPane.test.tsx Tests action rendering and execution.
tracingganttchart/​src/​TracingGanttChart.ts Registers the action editor.
tracingganttchart/​src/​gantt-chart-model.ts Extends configuration types.
tracingganttchart/​sdk/​go/​tracing-gantt-chart.go Adds configurable chart construction.
tracingganttchart/​sdk/​go/​options.go Adds selection and action options.
tracingganttchart/​sdk/​go/​options_test.go Tests serialization and validation.
tracingganttchart/​sdk/​go/​actions.go Defines action types and constructors.
tracingganttchart/​schemas/​tracing-gantt-chart.cue Adds shared action schemas.
tracingganttchart/​schemas/​tests/​valid/​tracing-gantt-chart-actions.json Adds an action configuration fixture.
tracingganttchart/​rsbuild.config.ts Shares required Perses packages.
tracingganttchart/​package.json Declares added dependencies.
tracingganttchart/​cue.mod/​module.cue Adds shared schema dependency.
package-lock.json Records workspace dependency changes.
docs/​tracingganttchart/​README.md Documents actions and payloads.
docs/​tracingganttchart/​model.md Documents configuration fields.
docs/​tracingganttchart/​go-sdk.md Documents SDK options and examples.

Review effort: Balanced

Comment thread docs/tracingganttchart/README.md Resolved

@AntoineThebaud AntoineThebaud left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gladorme

Copy link
Copy Markdown
Member Author

WAIT RELEASE 0.55.0 BEFORE MERGE

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
@Gladorme
Gladorme force-pushed the ganttchart/item-actions branch from 13bc0e9 to cace634 Compare October 21, 2026 13:01

@andreasgerstmayr andreasgerstmayr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 💯

@Gladorme
Gladorme added this pull request to the merge queue Oct 27, 2026
Merged via the queue into perses:main with commit e7e283d Oct 27, 2026
17 checks passed
@Gladorme
Gladorme deleted the ganttchart/item-actions branch October 27, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants