fix: bind server health to configured product release - #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The server health route verified instance identity but constructed its selected operational installation without a configured product version. A reachable wrong release could therefore pass that service-level check.
Change
Server configuration v3 persists the running product version, upgrades v1/v2 configurations during initialization, and requires
/healthto return that exact release identity.Validation
PYTHONPATH=src python3 -m unittest tests.engineering.test_server_foundation tests.engineering.test_operational_installation(82 tests)Boundary
This is a health/identity correctness increment only; it performs no live service cutover or installation mutation.