improvement: accept rfc3339/humantime mix for start and end time - #1771
improvement: accept rfc3339/humantime mix for start and end time#1771nikhilsinhaparseable wants to merge 1 commit into
Conversation
mixed time support affects -
/api/v1/query
/api/v1/counts
/api/v1/query/context — explicit contextStartTime/contextEndTime
/api/prism/v1/services/traces/{list,detail}
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. WalkthroughThe PR adds shared parsing for RFC 3339, ChangesRelative time support
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to The change broadens accepted time formats for the listed query and trace APIs, and no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Description checkResolution Add the required Description section with the PR goal, chosen solution and rationale, and key implementation changes. Replace Fixes
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
mixed time support affects -
/api/v1/query
/api/v1/counts
/api/v1/query/context — explicit contextStartTime/contextEndTime
/api/prism/v1/services/traces/{list,detail}
Summary by CodeRabbit
New Features
now,now-1h, andnow+30min queries and log context time ranges.Bug Fixes