The suggestion chips size to their text, not the whole canvas - #334
Merged
Conversation
Every direct child of the chat canvas is forced to full height for the package's own layout, and the suggestion row is one of those children: it filled the canvas and stretched each chip into a circle drawn over the conversation. The row now sizes to its content and each chip to its own text. Measured in a browser: chips 26px tall in a 58px row, against a 779px canvas. The scrubber and the persona buttons hit this same rule before, which is why the comment names it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.chat-canvas > * { height: 100% }forces every direct child to full height for the package's own layout, and the next-message suggestion row is one of those children. It filled the canvas, and with the defaultalign-items: stretcheach chip inflated with it, drawing giant circles over the conversation.height: autoplusalign-items: flex-starton the row andheight: autoon the chips. Measured in a headless browser against the live app: chips 26px tall in a 58px wrapped row, canvas 779px. The conversation scrubber and the persona buttons hit this same rule before; the comment names it so the next component does not.